Closed Bug 1148380 Opened 9 years ago Closed 3 years ago

Tab Queue: Optimise code in GeckoApp onNewIntent for ACTION_VIEW when Tabs queued

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mhaigh, Unassigned)

References

Details

In the onNewIntent method in GeckoApp, when a ACTION_VIEW action is received and there is current Tab Queue data we perform a callback based path in order to open the tab queue data first and then the intent data, to ensure that tab created from the intent data is on top (last loaded tab) and selected.

This code path can be cleaned up by removing the callback and instead adjusting the tab queue data to include the data from the intent as the last item in the JSON array, this will ensure it's visible and selected.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1146589#c6 for more context
Summary: Optimise code in GeckoApp onNewIntent for ACTION_VIEW when Tabs queued → Tab Queue: Optimise code in GeckoApp onNewIntent for ACTION_VIEW when Tabs queued
No longer depends on: 1146589
Depends on: 1146589
Blocks: tab-queue-v2
No longer blocks: tab-queue
Assignee: mhaigh → nobody
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.