1148411 - [e10s] browser_markupview_html_edit_02.js causes unsafe CPOW usage warnings

Status: RESOLVED DUPLICATE of bug 1252099

(DevTools :: Inspector, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Mined from test logs

In browser/devtools/markupview/test/browser_markupview_html_edit_02.js:

https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l19
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l21
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l22

  {
    selector: "#badMarkup1",
    oldHTML: '<div id="badMarkup1">badMarkup1</div>',
    newHTML: '<div id="badMarkup1">badMarkup1</div> hanging</div>',
    validate: function*(pageNode, pageNodeFront, selectedNodeFront, inspector) {
      is(pageNodeFront, selectedNodeFront, "Original element is selected");

      let textNode = pageNode.nextSibling; <-- causes unsafe CPOW usage warning

      is(textNode.nodeName, "#text", "Sibling is a text element"); <-- causes unsafe CPOW usage warning
      is(textNode.data, " hanging", "New text node has expected text content"); <-- causes unsafe CPOW usage warning
    }
  },

...

https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l32
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l34
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l35

  {
    selector: "#badMarkup2",
    oldHTML: '<div id="badMarkup2">badMarkup2</div>',
    newHTML: '<div id="badMarkup2">badMarkup2</div> hanging<div></div></div></div></body>',
    validate: function*(pageNode, pageNodeFront, selectedNodeFront, inspector) {
      is(pageNodeFront, selectedNodeFront, "Original element is selected");

      let textNode = pageNode.nextSibling; <-- causes unsafe CPOW usage warning

      is(textNode.nodeName, "#text", "Sibling is a text element"); <-- causes unsafe CPOW usage warning
      is(textNode.data, " hanging", "New text node has expected text content"); <-- causes unsafe CPOW usage warning
    }
  },

...

https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l48
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l49

  {
    selector: "#badMarkup3",
    oldHTML: '<div id="badMarkup3">badMarkup3</div>',
    newHTML: '<div id="badMarkup3">badMarkup3 <em>Emphasized <strong> and strong</div>',
    validate: function*(pageNode, pageNodeFront, selectedNodeFront, inspector) {
      is(pageNodeFront, selectedNodeFront, "Original element is selected");

      let em = getNode("#badMarkup3 em");
      let strong = getNode("#badMarkup3 strong");

      is(em.textContent, "Emphasized  and strong", "<em> was auto created"); <-- causes unsafe CPOW usage warning
      is(strong.textContent, " and strong", "<strong> was auto created"); <-- causes unsafe CPOW usage warning
    }
  },

...

https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l62
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l63
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l64
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l65

  {
    selector: "#badMarkup4",
    oldHTML: '<div id="badMarkup4">badMarkup4</div>',
    newHTML: '<div id="badMarkup4">badMarkup4</p>',
    validate: function*(pageNode, pageNodeFront, selectedNodeFront, inspector) {
      is(pageNodeFront, selectedNodeFront, "Original element is selected");

      let div = getNode("#badMarkup4");
      let p = getNode("#badMarkup4 p");

      is(div.textContent, "badMarkup4", "textContent is correct"); <-- causes unsafe CPOW usage warning
      is(div.tagName, "DIV", "did not change to <p> tag"); <-- causes unsafe CPOW usage warning
      is(p.textContent, "", "The <p> tag has no children"); <-- causes unsafe CPOW usage warning
      is(p.tagName, "P", "Created an empty <p> tag"); <-- causes unsafe CPOW usage warning
    }
  },

...

https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l80
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l81
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l82
https://hg.mozilla.org/projects/holly/file/50e197279ad5/browser/devtools/markupview/test/browser_markupview_html_edit_02.js#l83

  {
    selector: "#badMarkup5",
    oldHTML: '<p id="badMarkup5">badMarkup5</p>',
    newHTML: '<p id="badMarkup5">badMarkup5 <div>with a nested div</div></p>',
    validate: function*(pageNode, pageNodeFront, selectedNodeFront, inspector) {
      is(pageNodeFront, selectedNodeFront, "Original element is selected");

      let p = getNode("#badMarkup5");
      let nodiv = getNode("#badMarkup5 div");
      let div = getNode("#badMarkup5 ~ div");

      ok(!nodiv, "The invalid markup got created as a sibling");
      is(p.textContent, "badMarkup5 ", "The <p> tag does not take in the <div> content"); <-- causes unsafe CPOW usage warning
      is(p.tagName, "P", "Did not change to a <div> tag"); <-- causes unsafe CPOW usage warning
      is(div.textContent, "with a nested div", "textContent is correct"); <-- causes unsafe CPOW usage warning
      is(div.tagName, "DIV", "Did not change to <p> tag"); <-- causes unsafe CPOW usage warning
    }
  }

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is test only.

Comment 2

[Julian Descottes [:jdescottes]]

Inspector bug triage. Filter on CLIMBING SHOES

Fixed by Bug 1252099.