1148458 - mach build incorrectly reports success on Linux when building on an NTFS partition.

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Mike Hoye [:mhoye]]

Attachment: Full build log from contributor.

A contributor has reported this error after a successful clobber build:

[doomkookie@doomkookie moz_cent]$ ./mach run
 0:01.17 /mnt/win/Users/Aisheng/mozillastuff/moz_cent/obj-build-release/dist/bin/firefox -no-remote -profile /mnt/win/Users/Aisheng/mozillastuff/moz_cent/obj-build-release/tmp/scratch_user

(process:24478): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
[24478] ###!!! ABORT: LoadSheetSync failed with error 80520012 loading built-in stylesheet 'resource://gre-resources/counterstyles.css': file /mnt/win/Users/Aisheng/mozillastuff/moz_cent/layout/style/nsLayoutStylesheetCache.cpp, line 378
[24478] ###!!! ABORT: LoadSheetSync failed with error 80520012 loading built-in stylesheet 'resource://gre-resources/counterstyles.css': file /mnt/win/Users/Aisheng/mozillastuff/moz_cent/layout/style/nsLayoutStylesheetCache.cpp, line 378

This is all happening on an NTFS filesystem mounted under Linux.

The full build log is attached. The contributor is testing a build in a shorter dirname now, but I suspect that what's happening here is that we're running into a problem with the NTFS max path length, failing a filesystem operation during packaging and not catching that failure. The build team has run into this problem before.

Comment 1

[(not currently active) Ted Mielczarek]

Alternately, it's possible that something is breaking because we can't make symlinks on the NTFS partition, although our copier code does try to fall back to copying if symlinking doesn't work.

I'm inclined to say building on an NTFS partition under Linux is something we should explicitly unsupport, with an early test and explicit error message.

Comment 2

[Gregory Szorc [:gps]]

I'm just going to declare that building on Linux on an NTFS mount is an unsupported build configuration.

If there is any action in this bug, it should be to abort the build when this situation is encountered.

Comment 3

[Mike Hoye [:mhoye]]

Ok, I've updated the docs with a note to the effect that this is unlikely to work.

Comment 4

[SUN Haitao]

Actually, it BUILDS right. The result works normally (enough to send this comment) after being copied with 'cp -rL'.

I suspect that the real problem is that Firefox cannot load some symlinked resources currently in such a situation.

Comment 5

[Mike Hoye [:mhoye]]

I suspect we're asking for trouble by making this a supported configuration, but if we update the docs we could add a note saying "this is unsupported, go read this, do you want to proceed?" rather than aborting.

Comment 6

[SUN Haitao]

It works fine on Fedora 25 with NTFS-3G 2017.3.23 now.