1148459 - Use new keywords API in tests

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

Use the new keywords API in
toolkit/components/places/tests/bookmarks/test_bookmarks.js

Comment 1

[Marco Bonardo [:mak]]

let's make this generic for all tests

toolkit/components/places/tests/browser/browser_bug248970.js
toolkit/components/places/tests/bookmarks/test_bookmarks.js
toolkit/components/places/tests/queries/head_queries.js
toolkit/components/places/tests/unit/test_398914.js
toolkit/components/places/tests/unit/test_preventive_maintenance.js
toolkit/components/places/tests/unit/test_placesTxn.js
toolkit/components/places/tests/unit/test_telemetry.js

Comment 2

[Marco Bonardo [:mak]]

Updated list:

toolkit/components/places/tests/autocomplete/head_autocomplete.js
toolkit/components/places/tests/browser/browser_bug248970.js
toolkit/components/places/tests/queries/head_queries.js
toolkit/components/places/tests/unit/test_preventive_maintenance.js
toolkit/components/places/tests/unit/test_placesTxn.js
toolkit/components/places/tests/unit/test_telemetry.js
toolkit/components/places/tests/unit/test_promiseBookmarksTree.js

Comment 3

[Marco Bonardo [:mak]]

I'm picking this bug.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8595387 [details] [diff] [review]
patch v1

Review of attachment 8595387 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/queries/head_queries.js
@@ +169,5 @@
>  
>          if (qdata.keyword) {
>            let itemId = yield PlacesUtils.promiseItemId(item.guid);
> +          yield PlacesUtils.keywords.insert({ url: qdata.uri,
> +                                              keyword: qdata.keyword });

Can remove the promiseItemId() call.

@@ +228,5 @@
>    this.isTag = obj.isTag ? obj.isTag : false;
>    this.tagArray = obj.tagArray ? obj.tagArray : null;
>    this.isLivemark = obj.isLivemark ? obj.isLivemark : false;
> +  this.parentGuid = obj.parentGuid ? obj.parentGuid
> +                                   : PlacesUtils.bookmarks.rootGuid;

Seems equivalent to:

this.parentGuid = obj.parentGuid || PlacesUtils.bookmarks.rootGuid;

::: toolkit/components/places/tests/queries/test_onlyBookmarked.js
@@ +26,5 @@
>  
>    // Add a bookmark that should not be in the results
>    { isBookmark: true,
>      uri: "http://bookmarked-elsewhere.com/",
> +    parentFolder: PlacesUtils.bookmarks.menuGuid,

parentGuid?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/624ec1ca79d5

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/624ec1ca79d5