1148652 - Make NativeDefineProperty (more) compliant for arrays, TypedArray views, and arguments objects

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

These three object types are implemented as "native" in SM, but classified as "exotic" in the standard because each has a custom [[DefineOwnProperty]] internal method:

*   Arrays: http://people.mozilla.org/~jorendorff/es6-draft.html#sec-array-exotic-objects-defineownproperty-p-desc

*   Arguments: http://people.mozilla.org/~jorendorff/es6-draft.html#sec-arguments-exotic-objects-defineownproperty-p-desc

*   TypedArrays: http://people.mozilla.org/~jorendorff/es6-draft.html#sec-integer-indexed-exotic-objects-defineownproperty-p-desc

We partially implement all the special cases in StandardDefineProperty. The goal here is to achieve the same level of compliance in NativeDefineProperty.

Comment 1

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=146b293e5dd1

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: part 1 - Move array-specific special cases to the top of NativeDefineProperty; update ArraySetLength to be able to cope with incomplete attrs

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: part 2 - Use mostly-compliant code for defining TypedArray elements, already used from StandardDefineProperty, in NativeDefineProperty as well

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: part 3 - Mark arguments.length as overridden when it is redefined via the C API. try: -b do -p linux64,linux64-st-an,macosx64,win32 -u all[x64,10.6,Windows XP] -t none

Comment 5

[Eric Faust [:efaust]]

Comment on attachment 8585018 [details] [diff] [review]
part 1 - Move array-specific special cases to the top of NativeDefineProperty; update ArraySetLength to be able to cope with incomplete attrs

Review of attachment 8585018 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 6

[Eric Faust [:efaust]]

Comment on attachment 8585020 [details] [diff] [review]
part 3 - Mark arguments.length as overridden when it is redefined via the C API.  try: -b do -p linux64,linux64-st-an,macosx64,win32 -u all[x64,10.6,Windows XP] -t none

Review of attachment 8585020 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 7

[Jason Orendorff [:jorendorff]]

(In reply to Eric Faust [:efaust] from comment #6)
> part 3 - Mark arguments.length as overridden when it is redefined via the C API.
>
> Nice catch.

Oh, I didn't catch this. Not a chance.

Our test suite did.

Comment 8

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3125cc5a7a65
https://hg.mozilla.org/integration/mozilla-inbound/rev/35a01c7e0f8d
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7c3cf0e526

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out (along with every other patch from that massive push) in https://hg.mozilla.org/integration/mozilla-inbound/rev/386c8b5b73c0 for talos other timeouts:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3fc49391f7fe&filter-searchStr=talos oth

Comment 10

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68fa62199799
https://hg.mozilla.org/integration/mozilla-inbound/rev/10f6a2d81358
https://hg.mozilla.org/integration/mozilla-inbound/rev/5147517c8a18

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68fa62199799
https://hg.mozilla.org/mozilla-central/rev/10f6a2d81358
https://hg.mozilla.org/mozilla-central/rev/5147517c8a18