1148677 - "Send to other devices" icon blurry in long-press send link context menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Long press a link, click share, and scroll to see send to other devices.

Affects pre-Android L too.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Seems like I need to supply a specific icon asset. What're the dimensions?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I think these are all application icon assets so they're huge - I'm not sure if this uses the 48dp x 48dp icon, or the 96dp x 96dp icon (I'd guess the former).

Send by the assets and I'll try them out!

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: appicon_shareplane.zip

Try these, I have one for 96px x 96px and another for 48px x 48px

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Can I get these assets in XHDPI form for testing (and I'll ping again for the full range of DPI for the size I actually need)?

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: appicon_shareplane_XHDPI.png

Try this!

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot post asset

I think that looks correct - can I get the full set of assets?

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: appicon_shareplane.zip

Attached.

Screenshot?

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: appicon_shareplane2.zip

These are smaller - try them instead.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot (pre commit)

(In reply to Anthony Lam (:antlam) from comment #8)
> These are smaller - try them instead.

The icons get scaled - it's always been that big. We'd need to add padding to get it to look smaller.

Comment 10

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: appicon2_shareplane.zip

Took a step back, discussed on IRC.

These assets are 48dp square, same as the build icons. They should be sharp in all dialogs now. But, we'll have to see.

Give these a try.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot (post commit)

Nice! I think this looks better all around!

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot (share menu)

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1148677/mcomella

/r/6485 - Bug 1148677 - Use larger shareplane icon. r=liuche

Pull down this commit:

hg pull -r 6ac8cb91b80047821e78af3d005d8049e9b23dfd https://reviewboard-hg.mozilla.org/gecko/

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8586930 [details]
MozReview Request: bz://1148677/mcomella

https://reviewboard.mozilla.org/r/6483/#review5427

::: mobile/android/base/widget/ActivityChooserModel.java
(Diff revision 1)
> -                    resolveInfo.icon = R.drawable.share_plane;
> +                    resolveInfo.icon = R.drawable.icon_shareplane;

I'm confused - I see that drawable/share_plane has been modified, but I don't see it used anywhere with this change. Can we remove it entirely?

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/6483/#review5491

> I'm confused - I see that drawable/share_plane has been modified, but I don't see it used anywhere with this change. Can we remove it entirely?

It was deleted - `hg log --stat` also just shows modification (I had to look at `hg log -p`) so I wonder if this is just a shortcoming of hg (and reviewboard's particular access of it).

I filed bug 1151121 for this.

Comment 16

[Chenxia Liu [:liuche]]

Comment on attachment 8586930 [details]
MozReview Request: bz://1148677/mcomella

https://reviewboard.mozilla.org/r/6483/#review5497

Ship It!

Comment 17

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/2f84f0216096

Comment 18

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8586930 [details]
MozReview Request: bz://1148677/mcomella

This should land in 38 because bug 1122302 landed in 38.

Approval Request Comment
[Feature/regressing bug #]: bug 1122302
[User impact if declined]:
  Users who long-press share an item (link or image) will see a blurry "Send to other devices" icon.

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  Low - we replace some existing assets with new ones and then rename the asset (and then change the reference in code). In the worst case, we reference a different asset and the icon appears incorrectly.

[String/UUID change made/needed]: None

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f84f0216096

Comment 20

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8586930 [details]
MozReview Request: bz://1148677/mcomella

Should be in 38 beta 4.

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-04-08-16-39-38.png

Verified as fixed using:
Device: Samsung S5 (Android 4.4)
Build: Firefox for Android 40.0a1 (2015-03-07)

Comment 22

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot (quick share)

I *think* I told you over irc that this didn't change, Anthony, and Teodora pointed out on irc that it did - just wanted to see what you think.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8bdcbb61cf68

Comment 24

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b70a93a7f10

Comment 25

[Catalin Suciu [:csuciu]]

Verified fixed on latest Aurora 39.0a2 and Beta 38.0b3 on Galaxy Note 3 with Android 4.4.2

Comment 27

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1148677 - Use larger shareplane icon. r=liuche