Closed
Bug 1148684
Opened 10 years ago
Closed 10 years ago
Compact SourceBuffer even if it contains only one chunk
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 39
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file)
1.25 KB,
patch
|
tnikkel
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Bug 1120271 introduced compacting support for SourceBuffer in ImageLib. Unfortunately, the code assumes that if there is only one chunk in the SourceBuffer, it doesn't need to be compacted. In cases where we got a false value for Content-Length, though, that's not true. Bug 1145762 is an example of such a situation.
The fix: we should always compact, even if we only have one chunk.
Assignee | ||
Comment 1•10 years ago
|
||
Here's the patch. I've verified that this fixes the issue in bug 1145762. (Even
without the GetContentLength fix in bug 1148682.)
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8584933 [details] [diff] [review]
Compact SourceBuffer even if it contains only one chunk.
Oops, just realized I didn't request review on this.
Attachment #8584933 -
Flags: review?(tnikkel)
Updated•10 years ago
|
Attachment #8584933 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8584933 [details] [diff] [review]
Compact SourceBuffer even if it contains only one chunk.
Approval Request Comment
[Feature/regressing bug #]: Bug 1120271 introduced the bug. This fixes bug 1145762.
[User impact if declined]: Unnecessary memory consumption, resulting in OOM in some cases.
[Describe test coverage new/current, TreeHerder]: On m-c, and I believe now m-a.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.
Attachment #8584933 -
Flags: approval-mozilla-beta?
Updated•10 years ago
|
status-firefox38:
--- → affected
Comment 7•10 years ago
|
||
Comment on attachment 8584933 [details] [diff] [review]
Compact SourceBuffer even if it contains only one chunk.
Regressions are unlikely, taking it.
should be in 38 beta 2
Attachment #8584933 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•