1148798 - nsSuiteGlue.js error NS_ERROR_UNEXPECTED when running tests because "app.update.lastUpdateTime.background-update-timer" isn't set

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

While working on Bug 1139958 I kept getting this error:
> JavaScript error: file:///c:/t1/hg/objdir-sm/dist/bin/components/nsSuiteGlue.js, line 669: NS_ERROR_UNEXPECTED
> : Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref]
Because "app.update.lastUpdateTime.background-update-timer" isn't set in the mochitest environment.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix

Test with prefHasUserValue() first

Comment 2

[[e-mail]]

Comment on attachment 8585066 [details] [diff] [review]
Patch v1.0 Proposed fix

>     // If there was an automated update tried in the interval, don't worry.
>-    var lastUpdateTime = Services.prefs.getIntPref("app.update.lastUpdateTime.background-update-timer");
>+    const LASTUPDATETIME = "app.update.lastUpdateTime.background-update-timer";
>+    var lastUpdateTime = Services.prefs.prefHasUserValue(LASTUPDATETIME) ?
>+                         Services.prefs.getIntPref(LASTUPDATETIME) : now;
>     if (lastUpdateTime + maxAge > now)
>       return false;
Please use the same constant for the pref as everyone else.
I'm not convinced that defaulting to now is correct, as if the preference doesn't exist that means that we haven't checked in the last three months.
It might be simpler to provide a default value in preferences (other consumers use 0 for unknown).

Comment 3

[Philip Chee]

Attachment: Patch v2 fix review issues

> Please use the same constant for the pref as everyone else.
Done.

> I'm not convinced that defaulting to now is correct, as if the preference 
> doesn't exist that means that we haven't checked in the last three 
> months.
> It might be simpler to provide a default value in preferences (other 
> consumers use 0 for unknown).
Done.

Comment 4

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/56708cdce292