1148938 - Temporarily test suggested tiles for Nightly and Aurora

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

In order to uplift suggested tiles in bug 1148859, we'll need wider testing that's on by default in Nightly and Aurora.

One simple fix is to change the newtab pref to a hardcoded data uri.

Alternatively, we could host a test file somewhere (probably not on people.mozilla).. maybe tiles.up.mozillalabs or even tiles.services.mozilla if it's easy enough for us to just upload.

Then we could point users to something like..

https://tiles.services.mozilla.com/test/suggested/%LOCALE%

Not sure if we need to allocate tile ids on our server. Or perhaps we can use a dummy id... of 0?

Comment 1

[Ed Lee :Mardak]

Ran into bug 1149021 when testing with this suggested tile that only had an image:

https://people.mozilla.org/~elee/suggested.unicorn.json

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Not entirely sure what the url will be yet, and this code should be removed before we hit release.. but just in case, I added the ifdef.

Comment 3

[Ed Lee :Mardak]

Attachment: v1 screenshot

Comment 4

[Ed Lee :Mardak]

adw, is there a good way to only set the temporary pref value for en-US? some ifdef AB_CD = en-US type thing? Or maybe we just do it through js code:

Instead of

this.__linksURL = Services.prefs.getCharPref(this._observedPrefs["linksURL"]);

if en-US: use alternate test url, e.g., https://people.mozilla.org/~elee/suggested.unicorn.json

Comment 5

[Ed Lee :Mardak]

Attachment: v2

This makes sure only en-US users get the suggested tile as only en-US has strings localized.

Comment 6

[Ed Lee :Mardak]

Attachment: v2.1

Ha.. brain fart. We don't need to remotely host a test tile as we aren't changing it. And by the time we do change it, we'll probably have the v3 endpoint up.

So just convert the file to data uri!

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8585711 [details] [diff] [review]
v2.1

Review of attachment 8585711 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Ed Lee :Mardak from comment #4)
> adw, is there a good way to only set the temporary pref value for en-US?
> some ifdef AB_CD = en-US type thing?

Not that I know of.  But this kind of seems like something you could use the experiments system for.  Have you considered that?  Anyhow, r+.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/568ab0081a4e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/568ab0081a4e

Comment 10

[Ed Lee :Mardak]

http://hg.mozilla.org/releases/mozilla-aurora/rev/4638866dd455

Comment 11

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Confirming this implementation on Windows 7 64-bit, Windows 8.1 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5 using:
- latest Nightly, build ID: 20150407030207;
- latest Aurora, build ID: 20150407004006.