Closed
Bug 1149215
Opened 7 years ago
Closed 7 years ago
Make nsLayoutUtils::GetWholeImageDestination use CSSIntSize instead of the unit-less nsIntSize.
Categories
(Core :: Layout, defect, P5)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
7.36 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=10560430ba3f
Attachment #8585594 -
Flags: review?(roc)
Comment 2•7 years ago
|
||
Aren't those image pixels rather than CSS pixels?
Comment 3•7 years ago
|
||
(In reply to David Baron [:dbaron] ⏰UTC-7 from comment #2) > Aren't those image pixels rather than CSS pixels? Yes, they are. As I mentioned in the other bug, Mats, we really need a unit class for image pixels.
Assignee | ||
Updated•7 years ago
|
Attachment #8585594 -
Flags: review?(roc)
Assignee | ||
Comment 4•7 years ago
|
||
OK, I'll leave this one as is while we consider using a separate unit type for image pixels in bug 1149515.
Assignee: mats → nobody
Depends on: 1149515
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8585594 [details] [diff] [review] fix After the recent discussion in bug 1149222 / bug 1149515, I think CSS pixels is the right unit to use here.
Attachment #8585594 -
Flags: review?(dholbert)
Assignee | ||
Comment 6•7 years ago
|
||
Actually, let's just remove this method. All it does is convert from CSS pixels to app units. The one caller from XUL can use ToAppUnits() instead.
Assignee: nobody → mats
Attachment #8585594 -
Attachment is obsolete: true
Attachment #8585594 -
Flags: review?(dholbert)
Attachment #8586794 -
Flags: review?(dholbert)
Comment 7•7 years ago
|
||
Comment on attachment 8586794 [details] [diff] [review] fix, v2 Looks good. >Bug 1149215 - Remove nsLayoutUtils::GetWholeImageDestination that use unit-less nsIntSize. r=dholbert extreme nit: "unitless" (unhyphenated) is a valid word [despite Firefox underlining it in squiggly red as I type this], so you could do s/unit-less/unitless/ if you like. References: http://ninjawords.com/unitless http://en.wiktionary.org/wiki/unitless
Attachment #8586794 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 8•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/809e54954e6f
Comment 9•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/809e54954e6f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•