1149215 - Make nsLayoutUtils::GetWholeImageDestination use CSSIntSize instead of the unit-less nsIntSize.

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10560430ba3f

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Aren't those image pixels rather than CSS pixels?

Comment 3

[Seth Fowler [:seth] [:s2h]]

(In reply to David Baron [:dbaron] ⏰UTC-7 from comment #2)
> Aren't those image pixels rather than CSS pixels?

Yes, they are.

As I mentioned in the other bug, Mats, we really need a unit class for image pixels.

Comment 4

[Mats Palmgren (inactive)]

OK, I'll leave this one as is while we consider using a separate unit type
for image pixels in bug 1149515.

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 8585594 [details] [diff] [review]
fix

After the recent discussion in bug 1149222 / bug 1149515, I think CSS pixels
is the right unit to use here.

Comment 6

[Mats Palmgren (inactive)]

Attachment: fix, v2

Actually, let's just remove this method.  All it does is convert from
CSS pixels to app units.  The one caller from XUL can use ToAppUnits()
instead.

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 8586794 [details] [diff] [review]
fix, v2

Looks good.

>Bug 1149215 - Remove nsLayoutUtils::GetWholeImageDestination that use unit-less nsIntSize.  r=dholbert

extreme nit: "unitless" (unhyphenated) is a valid word [despite Firefox underlining it in squiggly red as I type this], so you could do s/unit-less/unitless/ if you like.

References:
 http://ninjawords.com/unitless
 http://en.wiktionary.org/wiki/unitless

Comment 8

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/809e54954e6f

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/809e54954e6f