Closed Bug 1149230 Opened 10 years ago Closed 10 years ago

In-content preferences: missing padding between labels and learn more links in Advanced -> Data Choices panel

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: flod, Assigned: jaws)

References

Details

Attachments

(2 files)

Screenshot (Italian build)
84.60 KB, image/png
Details
Patch
991 bytes, patch
Gijs
: review+
lizzard
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
There's absolutely no padding between each label and the Learn more link. In some cases this causes the last letter of the label to almost overlap the link (see screenshot)
I think I may have regressed this with the work for EME. :-\ Will see if I have time to investigate later today.
Flags: needinfo?(gijskruitbosch+bugs)
Hrm, nope, not related to the EME change. Not sure how/when this regressed, then.
Flags: needinfo?(gijskruitbosch+bugs)
Pretty sure this was caused by bug 1075055.
Blocks: 1075055
Attached patch Patch — — Splinter Review
This is a simple patch that fixes this specific issue without causing much churn. I'd rather take this than refactor the layout here some more since we'll want to uplift this to beta.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8590318 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8590318 [details] [diff] [review] Patch Review of attachment 8590318 [details] [diff] [review]: ----------------------------------------------------------------- Quibble quibble, is 20px too much? Does 8px make more sense? Also, why !important? rs=me whichever way
Attachment #8590318 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #5) > Comment on attachment 8590318 [details] [diff] [review] > Patch > > Review of attachment 8590318 [details] [diff] [review]: > ----------------------------------------------------------------- > > Quibble quibble, is 20px too much? Does 8px make more sense? Also, why > !important? I couldn't notice any difference with 8px. !important is needed because of the rules at http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/in-content/common.css?rev=c4c897cad784#79
https://hg.mozilla.org/integration/fx-team/rev/45ed3255697c
Iteration: --- → 40.1 - 13 Apr
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 8590318 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: new feature for in-content prefs [User impact if declined]: text and links from different columns are too close to each other [Describe test coverage new/current, TreeHerder]: just visual change, css only [Risks and why]: none [String/UUID change made/needed]: none
Attachment #8590318 - Flags: approval-mozilla-beta?
Attachment #8590318 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/45ed3255697c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8590318 [details] [diff] [review] Patch Approving for uplift to aurora; seems very low risk and good to fix.
Attachment #8590318 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8590318 [details] [diff] [review] Patch Should be in 38 beta 4.
Attachment #8590318 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: