1149350 - Force reload for apps

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Myk mentioned on IRC that an app he works on occasionally runs with stale / cached scripts after installing a new version.

While we don't yet have a clear STR, in discussion we noticed that we could be pass "force: true" when reloading to bypass the cache.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1149350-Force-reload-for-apps.patch

Here is a sample change that does a "force reload" every time.

myk, bdahl, can you try it and let me know if this helps?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I'm building with it now and will start using it afterward.  I'll use it for a few days before reporting back, since the problem is intermittent, so it's hard to be sure.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8585802 [details] [diff] [review]
0001-Bug-1149350-Force-reload-for-apps.patch

Ok, I've been using my custom build with this patch for a few days, and I haven't had the problem again, nor have I noticed any regressions.  So this patch seems to address the problem, and at the very least it doesn't seem iatrogenic.  I think we should take it!

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8585802 [details] [diff] [review]
0001-Bug-1149350-Force-reload-for-apps.patch

Review of attachment 8585802 [details] [diff] [review]:
-----------------------------------------------------------------

Alex, should we just |force| reload like this in all cases, or make WebIDE on do so sometimes?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to J. Ryan Stinnett [:jryans] from comment #4)
> Alex, should we just |force| reload like this in all cases, or make WebIDE
> on do so sometimes?

..."only do so sometimes?"

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8585802 [details] [diff] [review]
0001-Bug-1149350-Force-reload-for-apps.patch

Review of attachment 8585802 [details] [diff] [review]:
-----------------------------------------------------------------

Hum it looks like the current production code usages of reload always use force=true.
(I mean the usages other than WebIDE ones, that are broken, per this bug)

So I think it is valuable to make it by default.
Only tests are calling reload without any argument, and I can easily imagine them failing because of that!

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3921bfb74f0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/1cf9ca8a9f1e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cf9ca8a9f1e