Closed Bug 1149359 Opened 9 years ago Closed 3 years ago

Split DefaultDoorHanger into separate subclasses

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: liuche, Unassigned)

References

Details

Currently, LoginDoorHanger is used for passwords doorhangers, and DefaultDoorHangers is used for *all other kinds* of doorhangers with some ugly runtime layout selection.

We should consider splitting this into different DoorHanger subclasses.

(The tradeoff is that we will need different layout files for each of these subclasses, which will take up a little more space but simplify the existing layout files and code path. And also make adding new doorhangers conceptually easier.)
Summary: Split Doorhangers into separate subclasses → Split DefaultDoorHanger into separate subclasses
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.