nsTArray.h:188:44: error: attempt to free a non-heap object 'tautoconst' [-Werror=free-nonheap-object]

RESOLVED FIXED in Firefox 40

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla40

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Bug 1138293 replaced a bunch of moz_free with free, and as a result, this triggered a warning in GCC that only happens under some particular circumstances (that particular one only happens on pgo linux64 builds, for instance).

Cf. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54202 it appears this warning is not accurate and may have plenty of false positives. We were getting away with it because we weren't using free() that much.

I propose that we disable this warning, on PGO builds only for now.
(Assignee)

Comment 1

3 years ago
Created attachment 8585920 [details] [diff] [review]
Don't make free-nonheap-object warning an error

Making this a r=me for landing, but hoping cpeterson will regularize.
Attachment #8585920 - Flags: review?(cpeterson)
(Assignee)

Comment 2

3 years ago
(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 8585920 [details] [diff] [review]
> Don't make free-nonheap-object warning an error
> 
> Making this a r=me for landing, but hoping cpeterson will regularize.

To make things clearer, this needs landing to unbust linux64 pgo builds after bug 1138293.
https://hg.mozilla.org/mozilla-central/rev/df2769aef7f6
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8585920 [details] [diff] [review]
Don't make free-nonheap-object warning an error

Review of attachment 8585920 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8585920 - Flags: review?(cpeterson) → review+

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.