1149430 - No more dev edition theme on nightly

Status: RESOLVED WONTFIX

(DevTools :: General, defect)

Description

[kud]

Attachment: screenshot 2015-03-31 at 10.43.30.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150330114816

Steps to reproduce:

The dev edition theme isn't available anymore. Even if you click on the button.



Expected results:

It should works! :)

Oh and by the way. Yesterday, the dev edition theme was available via the theme list, which is was cool. A button to active it isn't a good idea in my opinion.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The theme work was temporarily backed out.  It will be relanded in bug 1148996.

Comment 2

[kud]

Thank you jryans.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Erwann Mest from comment #0)
> Created attachment 8585945 [details]
> screenshot 2015-03-31 at 10.43.30.png
> 
> User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0)
> Gecko/20100101 Firefox/40.0
> Build ID: 20150330114816
> 
> Steps to reproduce:
> 
> The dev edition theme isn't available anymore. Even if you click on the
> button.
> 

Is the button not visible at all?  That pref could have been cleared out after you pulled down the updated version.  You may need to set browser.devedition.theme.showCustomizeButton = true and then restart the browser to get it to show back up.  Hopefully it will be back in the addon manager soon.

Comment 4

[kud]

- 2 or 3 versions ago, it wasn't a button but a theme listed in "themes": new feature, good point
- now, it comes back as a button ("use dev edition theme"): regression in my point of view
- `browser.devedition.theme.showCustomizeButton` is already as true
- `browser.devedition.theme.enabled` also as true

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Erwann Mest from comment #4)
> - 2 or 3 versions ago, it wasn't a button but a theme listed in "themes":
> new feature, good point
> - now, it comes back as a button ("use dev edition theme"): regression in my
> point of view
> - `browser.devedition.theme.showCustomizeButton` is already as true
> - `browser.devedition.theme.enabled` also as true

OK, so the button is working then?  I took the wording in the description to mean that the button didn't work.  The button will go away again once Bug 1148996 lands.

Comment 6

[kud]

The button works and changes `browser.devedition.theme.enabled` property but nothing appears about firefox theming.

Comment 7

[kud]

In other words, I am currently with the default firefox theme. I don't/can't have dev edition theme.

Comment 8

[Brian Grinstead [:bgrins]]

(In reply to Erwann Mest from comment #7)
> In other words, I am currently with the default firefox theme. I don't/can't
> have dev edition theme.

Oh, that's probably because still you have a lightweight theme ID selected (the devedition theme).  Can you try resetting the lightweightThemes.selectedThemeID pref?

Comment 9

[kud]

`lightweightThemes.selectedThemeID;[e-mail]` -> reset

Oh my gooooooooooooooood, it works ^^

Thank you Brian. ;)

Comment 10

[kud]

It works pretty good now, thank you. :)