Closed Bug 1149438 Opened 6 years ago Closed 6 years ago

keyboard shortcut (hotkey) for "Edit" button

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: gerv, Unassigned)

References

Details

Attachments

(1 file)

Can we please have a key combination for the Edit button, as I think it's something people will be wanting to do quite frequently.

Gerv
OS: Linux → All
Summary: Hotkey for "Edit" button → keyboard shortcut (hotkey) for "Edit" button
Attached patch 1149438_1.patch β€” β€” Splinter Review
- adds a hotkey of "e" (or ctrl+e, or cmd+e) to enter edit mode
- escape will cancel edit mode
Assignee: nobody → glob
Status: NEW → ASSIGNED
Attachment #8587218 - Flags: review?(dylan)
If Escape cancels edit mode, does it reset all the fields to their original values? If it just hides them, then someone might be in for a surprise if they edit, change some fields, decide not to do that, press Escape, then "just add a comment" and their old changes get submitted...

This seems like an inherent problem with the cancellability of Edit mode.

Gerv
(In reply to Gervase Markham [:gerv] from comment #2)
> If Escape cancels edit mode, does it reset all the fields to their original
> values?

yes - https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BugModal/web/bug_modal.js#L375
Comment on attachment 8587218 [details] [diff] [review]
1149438_1.patch

Review of attachment 8587218 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Although I tend to hate hotkeys like this, as they make my usage of vimperator more difficult. I'm niche enough to not warrant a userpref though.
Attachment #8587218 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   2c9db01..952a511  master -> master
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
i had to change it to just ctrl+e, because it interfered with normal typing.

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   952a511..6d59489  master -> master
Blocks: 1152118
Assignee: glob → nobody
Component: User Interface: Modal → User Interface
You need to log in before you can comment on or make changes to this bug.