114956 - Crashed on OK to prefs changing all labels' text.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[laurel]

Using dec 12 commercial trunk build

After changing all five labels' text in preferences dialog, upon OK I crash
sometimes.  I've seen two crashes out of about 5 times doing this (tried on a
couple different profiles).

Comment 1

[laurel]

Attachment: talkback 400267

Comment 2

[Sean Su]

Attachment: patch to fix crash

I can't reproduce the crash, but from the talkback report, this patch should
fix the crash.	The first fix in the patch is the real fix for this bug.  The
other two references to mOutliner are just others that I found that were not
being checked for null.

I don't know the cause of mOutliner being null.

Laurel, what kind of system is your win98 machine? (speed, memory)

Comment 3

[laurel]

Dell precision 210, Pentium III, 128 Mb ram.

Comment 4

[(not reading, please use [e-mail] instead)]

your bulletproofing approach looks good, marking 0.9.7, as this would be good 
to get into 0.9.7.

instead of 

if (mOutliner)
  mOutliner->Invalidate();

consider:

NS_ASSERTION(mOutliner, "no outliner, see bug #114956");
if (mOutliner)
  mOutliner->Invalidate();

that will turn this bug into an assertion, so if we see it again we can figure 
out what's going on.

sr=sspitzer if you make that change.

something to try:  try changing those pref values when the thread pane is 
empty, or when account central is showing.

Comment 5

[Sean Su]

Attachment: patch with NS_ASSERTION added

It still does not crash when the thread pane is empty, or when account central
is showing.

Comment 6

[Sean Su]

Comment on attachment 61608 [details] [diff] [review]
patch with NS_ASSERTION added

got sr=sspitzer, seeking r=

Comment 7

[David :Bienvenu]

Comment on attachment 61608 [details] [diff] [review]
patch with NS_ASSERTION added

r=bienvenu

Comment 8

[racham]

r=bhuvan for attachment 61608 [details] [diff] [review].

Comment 9

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 10

[Sean Su]

patch checked in.

Comment 11

[laurel]

Looks good so far on win98 using dec17 commercial trunk build.  Have tried many
times changing all labels and was not able to reproduce crash.  Will do some
further testing on other platforms, too, before closing this as verified.

Comment 12

[laurel]

OK using dec18 commercial trunk build: win98, linux rh6.2, mac OS X