Closed
Bug 1149585
Opened 11 years ago
Closed 11 years ago
No save password prompt on Facebook & Twitter
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: aaronmt, Assigned: wesj)
References
Details
(Keywords: reproducible, Whiteboard: [parity=safari][parity=chrome])
Attachments
(1 file)
Attempt to sign into Facebook. There is no save password prompt. This is on a build on master including https://github.com/mozilla/firefox-ios/pull/164/files the groundwork required to show prompts.
Both Safari and Chrome show a save password prompt.
--
iPhone 6 (8.2)
|
Reporter | |
Comment 1•11 years ago
|
||
Same behaviour on Twitter
Summary: No save password prompt on Facebook → No save password prompt on Facebook & Twitter
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → wjohnston
tracking-fennec: ? → +
|
|
Assignee | |
Comment 2•11 years ago
|
||
Bad last second rename hurt things here, but I also fixed a few other bugs. For instance, Twitter broke because it includes two forms, and we used the wrong one when deciding whether to save or not. I've also seen cases where two snackbars can appear. I limited the PasswordManager for each Browser to only showing one here.
Attachment #8587626 -
Flags: review?(sarentz)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8587626 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/298
Looks good. I am seeing the snackbar for the first time when I log in to a site.
Attachment #8587626 -
Flags: review?(sarentz) → review+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•