1149707 - Implement a real active state for buttons

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Marcia Knous [:marcia]]

Using the latest github pull, on Flame and LG device - see attached screenshot. https://github.com/mozilla/buddyup/commit/f3d7add22ddb8c99b055a688fd0a134a3e77ad41

STR:
1. Select a question anywhere in the BuddyUp app
2. Receive a black highlight around the text before it moves to the next screen.

Seen on multiple devices including Flame and LG. Tough to get a screenshot because of the timing...

Comment 1

[Marcia Knous [:marcia]]

These devices are running 2.0

Comment 2

[Anthony Ricaud (:rik)]

Attachment: outline.png

Is this what you're seeing?

Comment 3

[Anthony Ricaud (:rik)]

We started seeing that because of the transitions. It has always been there, just not visible when we didn't have transitions.

Comment 4

[Marcia Knous [:marcia]]

(In reply to Anthony Ricaud (:rik) from comment #2)
> Created attachment 8586699 [details]
> outline.png
> 
> Is this what you're seeing?

Yes, this is what I am seeing.

Comment 5

[Anthony Ricaud (:rik)]

Renaming to include more work

Comment 6

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla/buddyup/pull/146

Comment 7

[Rehan Dalal (Inactive)]

Comment on attachment 8589146 [details] [review]
https://github.com/mozilla/buddyup/pull/146

r+ with nits fixed.

Comment 8

[Anthony Ricaud (:rik)]

https://github.com/mozilla/buddyup/commit/effcc71a7e3124b9ca0b0ebe4cdb757b5c267af0

With this, buttons should stay active after you lift your finger. Clicking on a question looks better.