1149715 - [Bluetooth] Lose Access to Active Request when Clearing notifications

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Oliver Nelson [:oliverthor]]

Description:
When a user has an active bluetooth transfer request to them, they will observe that if they were to "Clear Notifications", they will lose the ability to respond to this request. The transfer request is still "active" on the other device, but they cannot send another signal of the same request.

PreReq:
* 2nd phone
* image in gallery to transfer
Repro Steps:
1) Update 2x Flame devices to 20150331010203
2) Activate 'Bluetooth" and sync up the two devices
3) On one device (with an image to transfer), open gallery and share via bluetooth
4) On opposite device, observe request in notification tray.
5) Clear Notifications containing the request.

Actual:
Device has no way of responding to a bluetooth transfer request after clearing notifications

Expected:
Device may view open Bluetooth transfer requests (widget in tray/options in Settings)


Environmental Variables:
--------------------------------------------------

Device: Flame 3.0
Build ID: 20150331010203
Gaia: a249df8f4c84fe0a139741f05a534d36996ea7b8
Gecko: 8af276ab8636
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0
--------------------------------------------------

Device: Flame 2.2
BuildID: 20150331002503
Gaia: cc11248ab69f13e89416c8e6bb2e184187e72088
Gecko: 90a26917ee8f
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------

Device: Flame 2.1
BuildID: 20150331001200
Gaia: 6f39e4e876152de1dcdcc0e7656197f22f105e4b
Gecko: 275ad18f587b
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
--------------------------------------------------

Device: Flame 2.0
BuildID: 20150331000204
Gaia: 896803174633fc6acd3fd105f81c349b8e9b9633
Gecko: 9c12f28cc73f
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
--------------------------------------------------


Repro frequency: always
video- https://youtu.be/Si7lRmkXr54
logcat

Comment 1

[Peter Bylenga [:PBylenga]]

NI on component owner (Bluetooth and Bluetooth File Transfer) for nomination decision.  Issue could possibly lead to a memory leak.

Comment 2

[Teri Wen [:twen]]

Nominate for 3.0 work, clearing notification will disable function completely and lead to failed file transfer.

Comment 3

[[e-mail]]

I think we can do not much if user choose "Clear Notifications" first.

ni harly for UX

Comment 4

[Harly Hsu[:harly]]

I think from a user perspective, the bluetooth transfer notification should not be cleared when user presses the "Clear Notifications" button. Is it possible to have it not clear like system update notification?

Comment 5

[[e-mail]]

Currently there's no way to "Clear Notifications" for normal notifications, I'd research how much works it needs to solve this issue.

Comment 6

[[e-mail]]

@kevin do you know if its possible to keep a normal notification not be cleared, when user press the "Clear Notifications"?

Comment 7

[Kevin Grandon :kgrandon]

I don't know off the top of my head, but I'm going to forward the request to Mike or Alberto to see if they have any ideas here.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Fred Lin [:gasolin] from comment #6)
> @kevin do you know if its possible to keep a normal notification not be
> cleared, when user press the "Clear Notifications"?

It is indeed possible. Currently what you need to do is set the `noclear` mozbehavior flag on the notification. See this marionette test [1].

However, going forward the correct way is to use the `sticky` attribute [2]. We have not implemented this yet, but Rober Bindar is currently working on making sure we adhere to the spec, so we will be deprecating `noclear` in favor of `sticky` soon. To make sure you don't have to change your code, you can include both flags in the Notification constructor with a note in the comments saying you should remove the `noclear` flag soon.

1.) https://github.com/mozilla-b2g/gaia/blob/c0c218fe20ff4d07a7dd8777ea7d6835c89d663b/apps/system/test/marionette/notification_behavior_test.js#L67
2.) https://notifications.spec.whatwg.org/#sticky-preference-flag

Comment 9

[Robert Bindar]

This is going to take me a while, I'm stuck with some marionette tests. I'd suggest you use the current "noclear" flag, land this stuff and when I'll get back to it I'll make sure everything is consistent with the spec naming.

Comment 10

[[e-mail]]

Thanks for insights! So the implement will just need

1. add the flag in notification

Expect result:
* The notification wont be cleared when user press 'clear notificatoin'
* The notification will only be cleared when user tap the notification.
* The result will pop up a pair view, or show the expired dialog after receiving 'bluetooth-cancel' message.

Comment 11

[[e-mail]]

Ooh I mixed the 3rd. expect result:

* tap the notification will pop up a `bluetooth transfer request`.

what action should be happen after request expired need to be determined after testing..

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1149715 > mozilla-b2g:master

Comment 13

[[e-mail]]

Comment on attachment 8641006 [details] [review]
[gaia] gasolin:issue-1149715 > mozilla-b2g:master

Add the flag then the notification is not cleared when tap the `clear all` link.

The transfer request behavior is remain the same as it was. (tap it will close the notification item)

Comment 14

[[e-mail]]

@Harly please help add this case in UX spec so we can track the change.

Comment 15

[Aaron Wu]

marked as 2.5+

Comment 16

[Harly Hsu[:harly]]

NI Tori to add this use case to the BT spec.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8641006 [details] [review]
[gaia] gasolin:issue-1149715 > mozilla-b2g:master

Thanks!

Comment 18

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/4565a2f2104946575e7c0dbdd67e86daa558b022

thanks!

Comment 19

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Receiving a bluetooth request, the notification won't be cleared when user taps 'clear notificatoin'. The notification will only be cleared when user tap the notification.
See attachment: verified_Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150812150204
Gaia Revision          52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gaia Date              2015-08-12 16:40:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cf932fc931dcd19f425934db79bec641ebe2a8a9
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150812.182303
Firmware Date          Wed Aug 12 18:23:12 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150812230643
Gaia Revision          52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gaia Date              2015-08-12 16:40:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150812.222959
Firmware Date          Wed Aug 12 22:30:07 UTC 2015
Bootloader             s1

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_Aries_v2.5.3gp