Closed
Bug 114973
Opened 23 years ago
Closed 23 years ago
nsPluginInstanceOwner::GetParameters() shouldn't return an error on 0 parameters
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: beard, Assigned: peterl-bugs)
Details
Attachments
(1 file)
|
1.97 KB,
patch
|
serhunt
:
review+
beard
:
superreview+
brendan
:
approval+
|
Details | Diff | Splinter Review |
The MRJ Java plugin currently relies on the fact that if there aren't any parameters, that NS_OK is returned. The plugin assumes that something has gone terribly wrong if the GetParameters() returns an error. The fix is simple, simply remove the code which returns an error if (!mNumCachedParams). Perhaps we should return an error if the element is <EMBED>, but certainly not if it is <OBJECT> or <APPLET>.
|
||
Comment 1•23 years ago
|
||
GetParameters() shouldn't have a side effect of checking for EMBED tags, that's what GetTagType() is for. Fixed up patch on it's way....
Assignee: av → peterl
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 61553 [details] [diff] [review] patch to return success for 0 parameters r=av
Attachment #61553 -
Flags: review+
|
Reporter | |
Comment 4•23 years ago
|
||
Comment on attachment 61553 [details] [diff] [review] patch to return success for 0 parameters sr=beard
Attachment #61553 -
Flags: superreview+
|
||
Comment 5•23 years ago
|
||
Comment on attachment 61553 [details] [diff] [review] patch to return success for 0 parameters a=brendan@mozilla.org for checkin to 0.9.7. /be
Attachment #61553 -
Flags: approval+
|
|
||
Updated•23 years ago
|
Keywords: mozilla0.9.7+
|
|
||
Comment 6•23 years ago
|
||
Patch in trunk, marking FIXED.
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•