Closed
Bug 1149791
Opened 10 years ago
Closed 10 years ago
API allows submission of 0-star ratings
Categories
(Marketplace Graveyard :: API, defect, P4)
Tracking
(Not tracked)
VERIFIED
FIXED
2015-08-25
People
(Reporter: krupa.mozbugs, Assigned: lucky.lavish, Mentored)
References
()
Details
(Whiteboard: [good first bug][lang=py][see comment 2])
Attachments
(2 files, 2 obsolete files)
|
460.55 KB,
image/png
|
Details | |
|
1.84 KB,
patch
|
Details | Diff | Splinter Review |
missing rating.png
steps to reproduce:
1. Load https://marketplace-altdev.allizom.org/app/artisanal-salad/ratings
2. Notice the second review which has no rating
expected behavior:
Ratings are required to submit user reviews. So, there should be no review with empty
actual behavior:
There are reviews with no rating
|
||
Comment 1•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-04-07
|
||
Comment 2•10 years ago
|
||
When using the submit a review form I couldn't reproduce the issue any longer. Stars are required to submit a review.
But using api calls I managed to submit a review without stars.
Please view this screencast: http://screencast.com/t/oeWnOaonC5h
link to the app: https://marketplace-altdev.allizom.org/app/20/ratings
I'm not sure that this workaround was in scope of this bug, but it is still possible to have reviews with no stars.
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 3•10 years ago
|
||
That's a bug in a different part of the code -- renaming and removing from tracker
No longer blocks: 1059418
Status: REOPENED → NEW
Component: Consumer Pages → API
Priority: -- → P4
Summary: Fake apps have reviews with no rating → API allows submission of 0-star ratings
|
|
||
Updated•10 years ago
|
Target Milestone: 2015-04-07 → ---
|
||
Updated•10 years ago
|
Whiteboard: [good first bug][lang=py][see comment 2]
|
Assignee | |
Comment 4•10 years ago
|
||
I have worked on this bug and tested locally and its not re-producible.
here is the pull request please verify.
PR: https://github.com/mozilla/zamboni/pull/3264
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
Please verify this PR https://github.com/mozilla/zamboni/pull/3270/
Travis build is passing.
Attachment #8649842 -
Attachment is obsolete: true
Attachment #8649860 -
Attachment is obsolete: true
Flags: needinfo?(mpillard)
|
|
||
Comment 7•10 years ago
|
||
Thanks!
Assignee: nobody → lucky.lavish
Status: NEW → RESOLVED
Closed: 10 years ago → 10 years ago
Flags: needinfo?(mpillard)
Resolution: --- → FIXED
Target Milestone: --- → 2015-08-25
|
|
||
Comment 8•10 years ago
|
||
|
|
||
Comment 9•10 years ago
|
||
Verified as fixed in FF43(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/GKagwpkh
Closing bug.
Status: RESOLVED → VERIFIED
|
|
||
Updated•10 years ago
|
Mentor: mpillard
You need to log in
before you can comment on or make changes to this bug.
Description
•