API allows submission of 0-star ratings

VERIFIED FIXED in 2015-08-25

Status

Marketplace
API
P4
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: krupa, Assigned: Lavish Aggarwal, Mentored)

Tracking

2015-08-25
Points:
---

Details

(Whiteboard: [good first bug][lang=py][see comment 2], URL)

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Created attachment 8586384 [details]
missing rating.png

steps to reproduce:
1. Load https://marketplace-altdev.allizom.org/app/artisanal-salad/ratings
2. Notice the second review which has no rating


expected behavior:
Ratings are required to submit user reviews. So, there should be no review with empty

actual behavior:
There are reviews with no rating
https://github.com/mozilla/zamboni/commit/fc55b01085401660631b3567de1b6374f37d1bad
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-04-07

Comment 2

3 years ago
When using the submit a review form I couldn't reproduce the issue any longer. Stars are required to submit a review.

But using api calls I managed to submit a review without stars.
Please view this screencast:  http://screencast.com/t/oeWnOaonC5h
link to the app: https://marketplace-altdev.allizom.org/app/20/ratings

I'm not sure that this workaround was in scope of this bug, but it is still possible to have reviews with no stars.
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
That's a bug in a different part of the code -- renaming and removing from tracker
No longer blocks: 1059418
Status: REOPENED → NEW
Component: Consumer Pages → API
Priority: -- → P4
Summary: Fake apps have reviews with no rating → API allows submission of 0-star ratings

Updated

3 years ago
Target Milestone: 2015-04-07 → ---

Updated

2 years ago
Whiteboard: [good first bug][lang=py][see comment 2]
(Assignee)

Comment 4

2 years ago
Created attachment 8649842 [details] [diff] [review]
bug has been fixed by validating rating field

I have worked on this bug and tested locally and its not re-producible.
here is the pull request please verify.

PR: https://github.com/mozilla/zamboni/pull/3264
(Assignee)

Comment 5

2 years ago
Created attachment 8649860 [details] [diff] [review]
travis build error fixed
(Assignee)

Comment 6

2 years ago
Created attachment 8650337 [details] [diff] [review]
new patch, squashing 2 commit

Please verify this PR https://github.com/mozilla/zamboni/pull/3270/

Travis build is passing.
Attachment #8649842 - Attachment is obsolete: true
Attachment #8649860 - Attachment is obsolete: true
Flags: needinfo?(mpillard)
Thanks!
Assignee: nobody → lucky.lavish
Status: NEW → RESOLVED
Last Resolved: 3 years ago2 years ago
Flags: needinfo?(mpillard)
Resolution: --- → FIXED
Target Milestone: --- → 2015-08-25
Fixed in https://github.com/mozilla/zamboni/commit/0e8715e369045dc306980bddcf68a70cdd12add5

Comment 9

2 years ago
Verified as fixed in FF43(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/GKagwpkh
Closing bug.
Status: RESOLVED → VERIFIED

Updated

2 years ago
Mentor: mpillard@mozilla.com
You need to log in before you can comment on or make changes to this bug.