Closed Bug 1149818 Opened 10 years ago Closed 10 years ago

Firefox ui tests update tests leak the firstrun tab and report an error

Categories

(Testing :: Firefox UI Tests, defect)

Version 3
x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla40

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

We're leaking the firstrun tab, which the harness reports as an error even though things are otherwise working ok. I'm not really sure why this looked ok when I ran the update tests during review, but the fix is pretty straightforward.
Oh, there was a merge yesterday. Maybe that page is only shown when the update crosses versions.
(In reply to Chris Manchester [:chmanchester] from comment #1) > Oh, there was a merge yesterday. Maybe that page is only shown when the > update crosses versions. Ah, some code in nsBrowserContentHandler.js suggests that is the case.
Attached file PR with fix
Attachment #8586440 - Flags: review?(ahalberstadt)
Thank you so much!
Attachment #8586440 - Flags: review?(ahalberstadt) → review+
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Blocks: 1148546
FYI, one of the follow-up enhancements for update tests will be to also check the first run page. So this pref will have to be removed again when we add those steps to the update tests.
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: