1149824 - SVGImageContext() should take a CSSIntSize instead of nsIntSize

Status: RESOLVED DUPLICATE of bug 1149222

(Core :: Graphics: ImageLib, defect)

Description

[Daniel Holbert [:dholbert]]

SVGImageContext's 'aViewportSize' constructor-arg is the viewport-size (in CSS pixels) and is used to size the internal SVG document's viewport.

It should probably have type "CSSIntSize" to make it clearer that it's in CSS pixels, and not in dev pixels.

In particular / to make it more concrete: if a document with SVG images gets a full-page-zoom, and its images are now mapped to larger dev-pixel area on-screen, we still want to keep passing in the same 'aViewportSize' to their SVGImageContext objects when drawing.

This would be clearer if we used the CSSIntSize type, I think.

Comment 1

[Mats Palmgren (inactive)]

This is what bug 1149222 part 1 does, right?

Comment 2

[Daniel Holbert [:dholbert]]

Oh, you're quite right. :) I hadn't looked at the earlier patches there.