Closed
Bug 1149897
Opened 9 years ago
Closed 9 years ago
PerformanceStatsService data is not monotonic
Categories
(Toolkit :: Performance Monitoring, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 1 obsolete file)
6.29 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
After switching from 16ms resolution to 1ms resolution, it appears that the data provided by the PerformanceStatsService is not monotonic. We should work around that limitation.
Assignee | ||
Comment 1•9 years ago
|
||
This patch implements a lightweight fix to force the times used by the stopwatch monitoring to be monotonic. Also, it reactivates a subtest deactivated in bug 674779, minus a subsubtest whose fix will be more sophisticated and will need bug 1150045. Incidentally, I suspect that the failures in the later subsubtest is due to a previous test using Jetpack to build an add-on but not cleaning up properly after itself (reading list? loop?)
Assignee: nobody → dteller
Attachment #8586822 -
Flags: review?(jdemooij)
Assignee | ||
Updated•9 years ago
|
Component: General → Performance Monitoring
Comment 2•9 years ago
|
||
Comment on attachment 8586822 [details] [diff] [review] monotonic.diff Review of attachment 8586822 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/Interpreter.cpp @@ +567,5 @@ > kernelTimeInt.LowPart = kernelFileTime.dwLowDateTime; > kernelTimeInt.HighPart = kernelFileTime.dwHighDateTime; > + // Convert 100 ns to 1 us, make sure that the result is monotonic > + *systemTime = runtime_-> > + stopwatch.systemTimeFix.monotonize(kernelTimeInt.QuadPart / 10); This fits on one line (99 chars) @@ +573,5 @@ > userTimeInt.LowPart = userFileTime.dwLowDateTime; > userTimeInt.HighPart = userFileTime.dwHighDateTime; > + // Convert 100 ns to 1 us, make sure that the result is monotonic > + *userTime = runtime_-> > + stopwatch.userTimeFix.monotonize(userTimeInt.QuadPart / 10); And here.
Attachment #8586822 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Applied feedback.
Attachment #8586822 -
Attachment is obsolete: true
Attachment #8587446 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
I had to back this out for frequent bc3 failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/dfee21ce5b78 https://treeherder.mozilla.org/logviewer.html#?job_id=8433454&repo=mozilla-inbound
Flags: needinfo?(dteller)
Assignee | ||
Comment 6•9 years ago
|
||
I believe that what you encountered is actually bug 1150259, which is anterior. I'll probably want to deactivate the test under Windows XP.
Flags: needinfo?(dteller)
Assignee | ||
Comment 7•9 years ago
|
||
So, Wes, how do you want to handle this? I have just put up for review a wallpaper patch for bug 1150259, btw.
Flags: needinfo?(wkocher)
Disabling your way to victory is more than acceptable to me. :)
Flags: needinfo?(wkocher)
Assignee | ||
Comment 9•9 years ago
|
||
In that case, let's land this bug, and let's handle bug 1150259 in bug 1150259.
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b342115be45c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•