Closed Bug 1150011 Opened 5 years ago Closed 5 years ago

Clean-up: Fix unused variables warnings in opt builds (table lookup in js/src/)

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: nbp, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #8586767 - Flags: review?(bhackett1024)
Blocks: buildwarning
Comment on attachment 8586767 [details] [diff] [review]
Add ifdef around DEBUG only code.

Review of attachment 8586767 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is the right fix.  From what I can tell the stuff turned on by JSGC_HASH_TABLE_CHECKS only does meaningful checking in DEBUG builds, e.g. CheckGCThingAfterMovingGC just asserts a couple things.  So rather than clutter the code with more #ifdef DEBUG, I think that JSGC_HASH_TABLE_CHECKS should only be turned on in DEBUG builds, which would mean it could just be removed and replaced with DEBUG.  But I'll defer to Jon on what to do here.
Attachment #8586767 - Flags: review?(bhackett1024) → review?(jcoppeard)
These checks are supposed to work anywhere JS_GC_ZEAL is defined, so the fix is to make these release asserts, which also fixes the warnings.
Assignee: nicolas.b.pierron → jcoppeard
Attachment #8586767 - Attachment is obsolete: true
Attachment #8586767 - Flags: review?(jcoppeard)
Attachment #8589032 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8589032 [details] [diff] [review]
bug1150011-hashtable-checks

Review of attachment 8589032 [details] [diff] [review]:
-----------------------------------------------------------------

This sounds good to me. :)
Attachment #8589032 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/d782ada80bb4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.