1150015 - mozilla-central nightly jobs fail to trigger l10n repacks

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Massimo Gervasini [:massimo]]

Nightly jobs on mozilla-central should trigger the l10n jobs but they fail with this error:

<type 'exceptions.TypeError'>: unhashable type: 'list'

from: buildbot/steps/trigger.py, line 95 in start

93    for scheduler in self.schedulerNames:
94      scheduler = properties.render(scheduler)
95*     if all_schedulers.has_key(scheduler):
96        sch = all_schedulers[scheduler]

in this case, "scheduler" is a list, not a string.

This is caused by https://hg.mozilla.org/build/buildbot-configs/rev/44068ffda891 and it was undetected by our tests.

We should add an assert statement here to prevent this kind of errors.


full log here: http://buildbot-master86.bb.releng.scl3.mozilla.com:8001/builders/OS%20X%2010.7%20mozilla-central%20nightly/builds/7/steps/trigger/logs/err.html#tbend (requires vpn)

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1261730
repository: mozilla-central
start_time: 2015-04-01T03:02:15
who: tomcat[at]mozilla[dot]com
machine: bld-linux64-spot-004
buildname: Linux x86-64 mozilla-central nightly
revision: 0b88606f8fe7

rm: cannot remove directory: `.'
rm: cannot remove directory: `.'
exceptions.TypeError: unhashable type: 'list'

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1261713
repository: mozilla-central
start_time: 2015-04-01T03:10:27
who: tomcat[at]mozilla[dot]com
machine: b-2008-ix-0091
buildname: WINNT 5.2 mozilla-central nightly
revision: 0b88606f8fe7

exceptions.TypeError: unhashable type: 'list'

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1261712
repository: mozilla-central
start_time: 2015-04-01T03:06:01
who: tomcat[at]mozilla[dot]com
machine: bld-lion-r5-064
buildname: OS X 10.7 mozilla-central nightly
revision: 0b88606f8fe7

exceptions.TypeError: unhashable type: 'list'

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1261714
repository: mozilla-central
start_time: 2015-04-01T03:07:10
who: tomcat[at]mozilla[dot]com
machine: b-2008-ix-0090
buildname: WINNT 6.1 x86-64 mozilla-central nightly
revision: 0b88606f8fe7

exceptions.TypeError: unhashable type: 'list'

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: [buildbotcustom] Bug 1150015 - mozilla-central nightly jobs fail to trigger l10n repacks.patch

Changes:

* Added an assertion to make checkconfigure fail if we try to append something that is not a string to triggered_nightly_schedulers
* Moved is_l10n_with_mh() check in the if branch; any parameter as 'enable_l10n' and 'l10n_platforms' is not taken in account if we are going to use repacks with mozharness.
* This patch does not create/remove any builders

Comment 6

[Massimo Gervasini [:massimo]]

Comment on attachment 8587394 [details] [diff] [review]
[buildbotcustom] Bug 1150015 - mozilla-central nightly jobs fail to trigger l10n repacks.patch

Thanks Chris,

landed: https://hg.mozilla.org/build/buildbotcustom/rev/d315c92d5ce3

Comment 7

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/d315c92d5ce3