1150074 - when a person blocks needinfo? requests, it prevents comments on a bug when there is an existing ni? request

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I ran into the scenario today where there was an outstanding needinfo? request on a bug.  I went to make a general comment on the bug and when I hit submit, it failed because it said the person was not accepting needinfo? requests anymore.

This should allow comments, but not new needinfo requests to people when they change their status.

Comment 1

[:glob ✱]

moving to the needinfo component, although it applies to the review ext as well.

Comment 2

[:glob ✱]

Attachment: 1150074_1.patch

- only validate the requestee when updating a bug if it has changed

Comment 3

[:glob ✱]

(In reply to Byron Jones ‹:glob› from comment #1)
> it applies to the review ext as well.

this doesn't appear to be the case; the check in the review extension already has a check for a requestee change.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8587170 [details] [diff] [review]
1150074_1.patch

Review of attachment 8587170 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

::: extensions/Needinfo/Extension.pm
@@ +205,5 @@
>      my $object = $args->{object};
>      return unless $object->isa('Bugzilla::Flag')
>          && $object->type->name eq 'needinfo'
> +        && $object->requestee
> +        && exists $args->{changes}->{requestee_id};

Not that it *really* matters, but ordering this so the $args check is first would save 4 method calls in the case that the requestee_id was not changed.

Comment 5

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   63567a9..ab32334  master -> master