Closed
Bug 1150111
Opened 10 years ago
Closed 9 years ago
Autophone - Add nytimes to page load tests
Categories
(Testing Graveyard :: Autophone, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: snorp, Assigned: bc)
References
Details
Attachments
(2 files)
283.74 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
676 bytes,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
We have it on eideticker, so might help connect some dots.
Assignee | ||
Comment 1•10 years ago
|
||
wlach, as I mentioned on irc, autophone uses quitter to cleanly shutdown pages as in https://github.com/mozilla/autophone/blob/master/files/base/initialize_profile.html
I can clone nytimes in the ep1 repo, but was wondering what you thought of the best organization. Should I create an autophone only directory; move twitter.com into it and put the clone of nytimes into it as well? Just let me know what approach you would like me to take.
You also mentioned using a url flag "?" to enable quitter. I'm not sure about that. It would work and have minimal overhead but seems a bit hacky. It might be better than having to clone everything though.
Flags: needinfo?(wlachance)
Comment 2•10 years ago
|
||
Actually, I think that will be fine, since it will basically be a no-op for eideticker. Disregard my comments on irc. :)
Flags: needinfo?(wlachance)
Assignee | ||
Comment 3•10 years ago
|
||
I just ran into an issue with the file names for nytimes.
nytimes/css.nyt.com/css/0.1/screen/build/homepage/styles.css?v=20120119.css
nytimes/css.nyt.com/css/0.1/screen/build/homepage/styles.css?v=20120119orig
nytimes/up.nytimes.com/index.html?d=0%2F1%2F&t=1&s=0&ui=&r=&u=www.nytimes.comwww.nytimes.com?
nytimes/wt.o.nytimes.com/dcsym57yw10000s1s8g0boozt_9t1x/njs.gif?dcsuri=%2Fnojavascript&WT.js=No&WT.tv=1.0.7
This is causing adb push to fail to copy with invalid argument at least with my local Nexus One/Android 2.3 devices with
ADBError: args: adb -s HT018P800097 wait-for-device push /mozilla/projects/autophone/src/bclary-autophone/files/ep1/nytimes/wt.o.nytimes.com /sdcard/tests/autophone/s1s2test/wt.o.nytimes.com, exitcode: 1, stdout: , stderr: push: /mozilla/projects/autophone/src/bclary-autophone/files/ep1/nytimes/wt.o.nytimes.com/dcsym57yw10000s1s8g0boozt_9t1x/njs.gif?dcsuri=%2Fnojavascript&WT.js=No&WT.tv=1.0.7 -> /sdcard/tests/autophone/s1s2test/wt.o.nytimes.com/dcsym57yw10000s1s8g0boozt_9t1x/njs.gif?dcsuri=%2Fnojavascript&WT.js=No&WT.tv=1.0.7
failed to copy '/mozilla/projects/autophone/src/bclary-autophone/files/ep1/nytimes/wt.o.nytimes.com/dcsym57yw10000s1s8g0boozt_9t1x/njs.gif?dcsuri=%2Fnojavascript&WT.js=No&WT.tv=1.0.7' to '/sdcard/tests/autophone/s1s2test/wt.o.nytimes.com/dcsym57yw10000s1s8g0boozt_9t1x/njs.gif?dcsuri=%2Fnojavascript&WT.js=No&WT.tv=1.0.7': Invalid argument
These files are the actually css and gif images and the parameters are not parsed as a query string. The way to fix this is to rename the files and edit the references to them to match the new file names. I don't think this will affect the eideticker tests at all.
wlach: Is this ok with you? Or should I just clone nytimes to an autophone specific directory?
Assignee: nobody → bob
Status: NEW → ASSIGNED
Flags: needinfo?(wlachance)
Summary: Add nytimes to page load tests → Autophone - Add nytimes to page load tests
Assignee | ||
Comment 5•10 years ago
|
||
wlach, if this is ok, can you go ahead and push it for me?
Attachment #8590534 -
Flags: review?(wlachance)
Assignee | ||
Comment 6•10 years ago
|
||
Sorry, I haven't switched to the pr model on phonedash yet. Simple patch though.
Attachment #8590540 -
Flags: review?(mcote)
Updated•10 years ago
|
Attachment #8590540 -
Flags: review?(mcote) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8590534 [details] [diff] [review]
bug-1150111.patch
Pushed ep1 nytimes change: http://git.mozilla.org/?p=automation/ep1.git;a=commit;h=8db1587f7fb192826af2a5c17bd982113551bbb5
Attachment #8590534 -
Flags: review?(wlachance) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://github.com/markrcote/phonedash/commit/daf44d9a3c9fef002a5203f8802869f6c648f5b7
and deployed to phonedash and phonedash-dev
synced to new ep1 master
https://github.com/mozilla/autophone/commit/3f2bbd42eb540099b4190d5731bf0b03a8279ad7
Assignee | ||
Comment 9•10 years ago
|
||
wlach: Did you use patch or git apply on the patch? Looking at the commit it doesn't look like the full patch was applied.
Assignee | ||
Comment 10•10 years ago
|
||
wlach, thanks. I was able to merge and push upstream.
http://git.mozilla.org/?p=automation/ep1.git;a=commit;h=6d01b2551df703e08587bf1885b2afdea6da6aaa
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 12•9 years ago
|
||
deployed 2015-05-06
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 13•9 years ago
|
||
The deployment failed and this is not yet enabled.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•9 years ago
|
||
fixed in bug 1163129
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•