1150131 - Make scene=2 check for auto-downloads a substring search on all URL parameters

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Chris More [:cmore]]

In bedrock, we can create download buttons that link to the second scene of the download page thus eliminating double button clicks from pages outside of /firefox/new/. Other websites like SUMO and now hello.firefox.com will be linking to the /firefox/new/ page and want to eliminate the double button click too. We need to be able to add additional UTM parameters to the link so that we can measure referral conversion rates.

The code for the second scene trigger is here:

https://github.com/mozilla/bedrock/blob/master/media/js/firefox/new.js#L282

The current check is when the query string equals ?scene=2 & and hash is #download-fx. The issue is that the scene=2 check is not a substring check and that makes the condition in new.js false when additional parameters are present. 

Can we change the new.js check for scene=2 to be a substring?

For example, we want this URL to work in Safari:

https://www.mozilla.org/firefox/new/?scene=2&utm_source=hello.firefox.com&utm_medium=referral&utm_campaign=non-webrtc-browser#download-fx

Currently, the only way to get it to work is by removing the additional parameters:

https://www.mozilla.org/firefox/new/?scene=2#download-fx

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: pull request

It should work...

Comment 2

[Alex Gibson [:agibson]]

(In reply to Chris More [:cmore] from comment #0)
> In bedrock, we can create download buttons that link to the second scene of
> the download page thus eliminating double button clicks from pages outside
> of /firefox/new/. Other websites like SUMO and now hello.firefox.com will be
> linking to the /firefox/new/ page and want to eliminate the double button
> click too. We need to be able to add additional UTM parameters to the link
> so that we can measure referral conversion rates.

Chris, we can still do this bug - but just to make you aware (I'm pretty sure we've discussed this in the past already), linking external sites directly the the second scene on /firefox/new will likely not work in older versions of IE, due to their security blocker. We work around this in bedrock as we can trigger the download before those users hit the /firefox/new page, but external sites don't have that luxury. If older versions of IE are a concern for those sites, I would recommend they just link to scene 1.

Comment 3

[Chris More [:cmore]]

(In reply to Alex Gibson [:agibson] from comment #2)
> (In reply to Chris More [:cmore] from comment #0)
> > In bedrock, we can create download buttons that link to the second scene of
> > the download page thus eliminating double button clicks from pages outside
> > of /firefox/new/. Other websites like SUMO and now hello.firefox.com will be
> > linking to the /firefox/new/ page and want to eliminate the double button
> > click too. We need to be able to add additional UTM parameters to the link
> > so that we can measure referral conversion rates.
> 
> Chris, we can still do this bug - but just to make you aware (I'm pretty
> sure we've discussed this in the past already), linking external sites
> directly the the second scene on /firefox/new will likely not work in older
> versions of IE, due to their security blocker. We work around this in
> bedrock as we can trigger the download before those users hit the
> /firefox/new page, but external sites don't have that luxury. If older
> versions of IE are a concern for those sites, I would recommend they just
> link to scene 1.

Very true. Though, for browsers that won't work linking to scene 2 (namely old IE), can't we just fall back to scene 2? Even within www.mozilla.org, having these parameters is important because the locale redirect drops the referring headers and thus it looks like direct traffic. Having the ability to passing additional UTM parameters to the second scene is a nice win for internal and external linking even if IE still won't work.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a550ed1a8a03939e7b14cb9eb961c55488c1eca7
Fix Bug 1150131 - Make scene=2 check for auto-downloads a substring search on all URL parameters

https://github.com/mozilla/bedrock/commit/feeeb64f5be1d4199c7538f9547fb667ce316e72
Merge pull request #2886 from kyoshino/bug-1150131-url-params

Fix Bug 1150131 - Make scene=2 check for auto-downloads a substring search on all URL parameters

Comment 5

[Chris More [:cmore]]

This is working on -dev now in Safari:

https://www-dev.allizom.org/firefox/new/?scene=2&utm_source=hello.firefox.com&utm_medium=referral&utm_campaign=non-webrtc-browser#download-fx

Prod test:

https://www.mozilla.org/firefox/new/?scene=2&utm_source=hello.firefox.com&utm_medium=referral&utm_campaign=non-webrtc-browser#download-fx