1150143 - [Search] Opening filled Rocketbar while returning to home will overlay homescreen with results

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150401_1056.txt

Description:
When the user has a search field input in rocketbar, while in another app, opening the 'Search' bar while returning to home via home button (even while at home) will leave the search results overlaying the homescreen.


Repro Steps:
1) Update a Flame to 20150401010204
2) Open 'Search' bar
3) Type 'jumanji' (or anything)
4) Observe results, tap home to maintain search bar field
5) Open the 'Settings' app (or stay at homescreen)
6) Tap 'Search' bar to open and immediately tap home button

Actual:
Phone will navigate to home with search results overlaying homescreen

Expected:
Phone will return to home and dismiss search results


Environmental Variables:
--------------------------------------------------

Device: Flame 3.0
Build ID: 20150401010204
Gaia: 03164bd160809747e6a198e0dba1b7c3ee7789f5
Gecko: 18a8ea7c2c62
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2
BuildID: 20150401002624
Gaia: 8b3086ad3963f1707e2bee9094baccafffe161c4
Gecko: 20b67213a047
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20150401001203
Gaia: 63c89e001010a9a43ea55afd39333ded3d5e83fc
Gecko: 30ac9a03343a
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------
Issue DOES NOT REPRO on 2.0 for flame devices:
Results: Search bar cannot be opened from other apps, only from top of homescreen. Offers different screen priority that seems to avoid causing overlay.

Device: Flame 2.0
BuildID: 20150401000204
Gaia: 896803174633fc6acd3fd105f81c349b8e9b9633
Gecko: 9c12f28cc73f
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
--------------------------------------------------


Repro frequency: 4/5 [mainly timing related]
See attached: 
video- https://youtu.be/tenmyZ7d2dM
logcat

Comment 1

[Kevin Grandon :kgrandon]

I'll take a look at this.

This also seems fairly bad as you can get pretty stuck, and have a terrible UX. Recommend blocking.

Comment 2

[Kevin Grandon :kgrandon]

We had a similar fix in bug 1132262 which we could also use here I think.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1150143_guard_against_early_closing > mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8586961 [details] [review]
[gaia] KevinGrandon:bug_1150143_guard_against_early_closing > mozilla-b2g:master

Alberto - since you helped me review bug 1132262, could you help me with this review as well? Thanks!

Comment 5

[Alberto Pastor [:albertopq]]

Comment on attachment 8586961 [details] [review]
[gaia] KevinGrandon:bug_1150143_guard_against_early_closing > mozilla-b2g:master

Not sure if I can r+ this, as I'm not a peer, but LGTM, thanks!

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Alberto Pastor [:albertopq] from comment #5)
> Not sure if I can r+ this, as I'm not a peer, but LGTM, thanks!

It's ok because the request is coming from a peer and you've done some rocketbar stuff in the past. Thank you for the review :)

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/96625ab6cb66bf0f0995c9edbd0eb57d5e3d39bd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this patch for Gaia v2.2 approval when you get a chance.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8586961 [details] [review]
[gaia] KevinGrandon:bug_1150143_guard_against_early_closing > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Likely there since feature implementation, but a pretty severe bug.
[User impact] if declined: Poor UX with rocketbar.
[Testing completed]: Manual and unit testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, fairly self-contained to rocketbar.
[String changes made]: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/45f39fc95e5c29401431fe6241850f5972cdb401

Comment 11

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: The search result does not overlay homescreen.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150408010203
Gaia: 84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gecko: 078128c2600a
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Environmental Variables:
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150408002503
Gaia: ea735c21bfb0d78333213ff0376fce1eac89ead6
Gecko: 43041c78052b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0