1150247 - Check if value is function before binding

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Eric Rahm [:erahm]]

Currently exception based logic is used to determine whether an export needs to be bound or not. This generates a fair amount of excpetions which themselves contain rather large stacks. We can reduce this overhead by simply checking whether the value is a function or not.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Bug 1150247 - Check if value is function before binding

Rather than attempting to bind non-functions and catching the exception this
explicitly checks if it is a function. This helps reduce memory consumption
needed for the exception stack traces. Realistically that will go away when GC
is run, but it throws off memory measurments prior to that.

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8587029 [details] [diff] [review]
Bug 1150247 - Check if value is function before binding

:ato, does this seem reasonable to you?

Comment 3

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5949449b538

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8587029 [details] [diff] [review]
Bug 1150247 - Check if value is function before binding

Review of attachment 8587029 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me!  It's worth noting that this code didn't change in bug 1107706, but it's a welcome change.

Comment 5

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f06f8b6c444b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f06f8b6c444b