Closed
Bug 1150352
Opened 11 years ago
Closed 11 years ago
Remove jemalloc's stdbool.h polyfill for MSVC
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
INVALID
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | affected |
People
(Reporter: briansmith, Assigned: briansmith)
References
Details
Attachments
(1 file)
|
1.00 KB,
patch
|
glandium
:
review-
|
Details | Diff | Splinter Review |
MSVC 2013 and later already provide a real stdbool.h. Some of Gecko's stdbool.h polyfills cause MSVC 2015 CTP 6 builds to fail because MSVC's internal headers include <stdbool.h>, so I'm removing them all.
Attachment #8587150 -
Flags: review?(mh+mozilla)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8587150 [details] [diff] [review]
Remove jemalloc's stdbool.h polyfill for MSVC
Review of attachment 8587150 [details] [diff] [review]:
-----------------------------------------------------------------
This file comes from upstream, and we don't use it because configure says
checking for inttypes.h... yes
which sets HAVE_INTTYPES_H, which makes us not add the directory in the include path:
https://dxr.mozilla.org/mozilla-central/source/memory/jemalloc/moz.build#51
Attachment #8587150 -
Flags: review?(mh+mozilla) → review-
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•