IonMonkey: MIPS: Fix build failure caused by Bug 1143011.

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

Trunk
mozilla40
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
/home/heiher/git/loongson/gecko-dev/js/src/jit/mips/Architecture-mips.cpp:109:17: error: ‘js::jit::FloatRegisterSet’ has no member named
 ‘addUnchecked’
             mod.addUnchecked((*iter).doubleOverlay());
/home/heiher/git/loongson/gecko-dev/js/src/jit/mips/Architecture-mips.cpp:111:17: error: ‘js::jit::FloatRegisterSet’ has no member named
 ‘addUnchecked’
             mod.addUnchecked(*iter);
/home/heiher/git/loongson/gecko-dev/js/src/jit/mips/BaselineIC-mips.cpp:84:58: error: conversion from ‘js::jit::AllocatableGeneralRegist
erSet {aka js::jit::AllocatableSet<js::jit::TypedRegisterSet<js::jit::Register> >}’ to non-scalar type ‘js::jit::GeneralRegisterSet {aka
 js::jit::TypedRegisterSet<js::jit::Register>}’ requested
     GeneralRegisterSet savedRegs = availableGeneralRegs(2);
....
(Assignee)

Comment 1

3 years ago
Created attachment 8587206 [details] [diff] [review]
IonMonkey-MIPS-Fix-build-failure-caused-by-Bug-11430.patch
Attachment #8587206 - Flags: review?(branislav.rankov)
Comment on attachment 8587206 [details] [diff] [review]
IonMonkey-MIPS-Fix-build-failure-caused-by-Bug-11430.patch

Review of attachment 8587206 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips/BaselineIC-mips.cpp
@@ +81,5 @@
>      Register scratchReg = R2.payloadReg();
>  
>      // DIV and MOD need an extra non-volatile ValueOperand to hold R0.
> +    AllocatableGeneralRegisterSet savedRegs(availableGeneralRegs(2));
> +    savedRegs.set() = GeneralRegisterSet::Intersect(GeneralRegisterSet::NonVolatile(), savedRegs.set());

nit: this line is too long. It should be less than 99 characters.
Attachment #8587206 - Flags: review?(branislav.rankov) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e960d9b2e6fd
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.