Closed Bug 1150520 Opened 5 years ago Closed 5 years ago

"Play DRM Content" checkbox is visible on XP

Categories

(Core :: Audio/Video, defect, P1)

x86_64
Windows XP
defect

Tracking

()

VERIFIED FIXED
mozilla40
Tracking Status
firefox37 --- unaffected
firefox38 + verified
firefox39 --- verified
firefox40 --- verified

People

(Reporter: adalucinet, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Reproducible on latest Developer Edition 39.0a2 (from 2015-04-01) and Firefox 38 beta 1 (Build ID: 20150330154247)
Affected platform: Windows XP x64

Steps:
1. Launch Nightly.
2. Go to Options/Content tab.

Expected result: Play DRM button is not available.

Actual result: Play DRM button is displayed.

Notes:
1. Screencast: http://goo.gl/5K9bDL
2. Based on https://support.mozilla.org/en-US/kb/enable-drm?as=u&utm_source=inproduct, Mac OS X, Linux and Windows XP are currently not supported. Since on OS X/Linux the button is disabled, I suppose the same behavior should have been encountered on XP too?!
3. When I toggle Play DRM button (false - true - false), DRM is automatically available on Add-ons Manager/Plugins tab; if I select to view more details, the focus changes to Get Add-ons tab (issue also visible in the screencast)
4. Couldn't check on 40.0a1 because of the crash bug 1150515.
Our front-end code may need a check similar to our GMP downloader[1] before showing the Play DRM button. Not sure if we have this check and it's not working as intended or if we have yet to add it. Justin, please feel free to forward the n-i request as you see fit.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/GMPUtils.jsm#48
Flags: needinfo?(dolske)
[Tracking Requested - why for this release]:

We don't support EME on XP yet, so we should hide the "Play DRM Content" checkbox (like we do on OS X and Linux).
Assignee: nobody → spohl.mozilla.bugs
Blocks: 1032660, EME
Priority: -- → P1
Summary: Play DRM button visible on XP → "Play DRM Content" checkbox is visible on XP
Conclusions from meeting:

1) Comment 0's screencast shows the CDM as being shown (stuck?) in a "pending install" state. Steven says that's not supposed to happen -- so either this was an issue since fixed, or something's broken. [The isPluginSupported() check in GMPUtils should be suppressing the CDM entry.] We should check, but this issue is a bit moot....

2) The desired outcome here is that Windows XP gets treated equivalently to Linux and OSX -- the UI and EME support should be disabled, because there is currently no XP-compatible CDM. The trick here is that we disable OSX/Linux at build time, whereas XP will need to be a runtime check.

3) We'd like to treat this as a blocker for 38 launch, even though our first partner will likely be doing platform detection and not serving EME content to XP users anyway.

We did add a platform-not-supported notification in bug 1131758, but only for 64-bit windows and Linux/OSX. Although the string there is suitably generic that we could use it for XP in the future, should that be something we want to implement later.

So:

* Alexandra, can you retest this on XP with a current Beta and Nightly to see if the CDM is still being shown? If so, let's file a new bug to fix that.

* Let's use this bug to suppress EME+UI at runtime on XP, per comment 1. I think Gijs is probably in the best state to fix this.
Assignee: spohl.mozilla.bugs → gijskruitbosch+bugs
Flags: needinfo?(dolske) → needinfo?(alexandra.lucinet)
Attached patch disable EME for Windows XP, (obsolete) — Splinter Review
Something like this? I'm kind of unhappy about doing this every startup but I don't know of a better way to do this...
Attachment #8593614 - Flags: review?(dolske)
Comment on attachment 8593614 [details] [diff] [review]
disable EME for Windows XP,

Review of attachment 8593614 [details] [diff] [review]:
-----------------------------------------------------------------

Talked with Gijs on IRC -- we don't want to do it this way, because then we can't if an XP user disabled the pref themselves, or if we did. Which would make re-enabling EME on XP when a CDM becomes available a touchy problem.

Suggested a pref-check wrapper, ala isDisabled() { pref == false || isXP }
Attachment #8593614 - Flags: review?(dolske) → review-
(In reply to Justin Dolske [:Dolske] from comment #5)
> Comment on attachment 8593614 [details] [diff] [review]
> disable EME for Windows XP,
> 
> Review of attachment 8593614 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Talked with Gijs on IRC -- we don't want to do it this way, because then we
> can't if an XP user disabled the pref themselves, or if we did. Which would
> make re-enabling EME on XP when a CDM becomes available a touchy problem.
> 
> Suggested a pref-check wrapper, ala isDisabled() { pref == false || isXP }

If we also want to disable clearkey etc., I think we also need changes in the media code. I don't know how important this is. cpearce, can you handle that if necessary? Any reason to leave clearkey in (dolske?)?
Flags: needinfo?(dolske)
Flags: needinfo?(cpearce)
My understanding is that we want this to be just like OS X / Linux -- and so no clearkey either. Hiding the EME UI means a user would have no way of disabling that.
Flags: needinfo?(dolske)
(In reply to Justin Dolske [:Dolske] from comment #3)

> * Alexandra, can you retest this on XP with a current Beta and Nightly to
> see if the CDM is still being shown? If so, let's file a new bug to fix that.

Unfortunately, I cannot test 40.0a1 on XP because it crashes at startup - seems like bug 1150515; cannot say for sure because crashes on Windows XP link to about/throttling by default (bug 1154298); Although, I confirm that on Firefox 38 beta 5 (Build ID: 20150416143048) "Play DRM Content" checkbox is still visible.
Flags: needinfo?(alexandra.lucinet)
(In reply to Justin Dolske [:Dolske] from comment #7)
> My understanding is that we want this to be just like OS X / Linux -- and so
> no clearkey either. Hiding the EME UI means a user would have no way of
> disabling that.

That the checkbox affects Clear Key is bug 1136707. I'm (strongly) of the opinion that we shouldn't provide UI, repack or compile-time option to disable Clear Key just like we don't provide such options to disable random Web Platform features. (Clear Key is not a third-party plug-in, nor non-Free Software nor DRM, so there's no need to be able to disable it on any of those counts.)
Attached file MozReview Request: bz://1150520/Gijs (obsolete) —
/r/7187 - Bug 1150520 - disable EME for Windows XP, r?dolske

Pull down this commit:

hg pull -r e445e26f4a9f6a429c5ca27320d7967ab5c6f3e6 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593941 - Flags: review?(dolske)
Attachment #8593614 - Attachment is obsolete: true
(tested locally on XP VM, can't push to try because it's closed...)
btw, we are considering disabling EME for Vista in our first release. We would then need to change this runtime version check to exclude Vista (NT 6.0).
Comment on attachment 8593941 [details]
MozReview Request: bz://1150520/Gijs

https://reviewboard.mozilla.org/r/7185/#review6007

Ship It!

::: browser/base/content/browser-eme.js
(Diff revision 1)
> +  get uiEnabled() {

I suppose it's a little sadmaking that we have 4 places to keep this code in sync (here, 2 pref UIs, and platform), but oh well!
Attachment #8593941 - Flags: review?(dolske) → review+
(In reply to :Gijs Kruitbosch from comment #6)
> If we also want to disable clearkey etc., I think we also need changes in
> the media code. I don't know how important this is. cpearce, can you handle
> that if necessary? Any reason to leave clearkey in (dolske?)?

Disabling ClearKey on WinXP is fine at this stage. We don't have H.264/AAC decoders that we can use on WinXP to decode content decrypted by ClearKey anyway.


(In reply to Henri Sivonen (:hsivonen) from comment #9)
> (In reply to Justin Dolske [:Dolske] from comment #7)
> > My understanding is that we want this to be just like OS X / Linux -- and so
> > no clearkey either. Hiding the EME UI means a user would have no way of
> > disabling that.
> 
> That the checkbox affects Clear Key is bug 1136707. I'm (strongly) of the
> opinion that we shouldn't provide UI, repack or compile-time option to
> disable Clear Key just like we don't provide such options to disable random
> Web Platform features. (Clear Key is not a third-party plug-in, nor non-Free
> Software nor DRM, so there's no need to be able to disable it on any of
> those counts.)

Edwin's probably going to do bug 1136707 next. I dunno if it's worth uplifting to 38.


(In reply to Chris Peterson [:cpeterson] from comment #12)
> btw, we are considering disabling EME for Vista in our first release. We
> would then need to change this runtime version check to exclude Vista (NT
> 6.0).

I have a fix for Vista in bug 1156131.
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/a5a233ce2241
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8593941 [details]
MozReview Request: bz://1150520/Gijs

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: UI will be visible on XP but it's not usable there, so let's not do that.
[Describe test coverage new/current, TreeHerder]: tangentially implicated with some tests, but no real test coverage for the UI right now, sadly.
[Risks and why]: pretty low, the changes are straightforward.
[String/UUID change made/needed]: nope
Attachment #8593941 - Flags: approval-mozilla-beta?
Attachment #8593941 - Flags: approval-mozilla-aurora?
Comment on attachment 8593941 [details]
MozReview Request: bz://1150520/Gijs

Agreed, we don't want that!
should be in 38 beta 6
Attachment #8593941 - Flags: approval-mozilla-beta?
Attachment #8593941 - Flags: approval-mozilla-beta+
Attachment #8593941 - Flags: approval-mozilla-aurora?
Attachment #8593941 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
QA Contact: alexandra.lucinet
Verified as fixed with Firefox 38 beta 6 (Build ID: 20150420134330) and latest Developer Edition 39.0a2 (2015-04-21) under Window XP 64 bit, and latest Nightly 40.0a1 (2015-04-21) under Windows XP 32 bit - "Play DRM Content" checkbox is no longer visible.
Attachment #8593941 - Attachment is obsolete: true
Attachment #8619954 - Flags: review+
Flags: qe-verify+ → qe-verify-
You need to log in before you can comment on or make changes to this bug.