1150523 - Support string based statuses in the Marionette Node.js client

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

In preparation for replacing number-based status codes in the Marionette server (bug 945729) we need to add support for the new string-based errors as described in the W3C WebDriver protocol.

This is the full list of errors: https://w3c.github.io/webdriver/webdriver-spec.html#dfn-error-code

The plan is to add in support for looking up exception classes by string as well as by number, then land the change to the remote end that removes number codes, then remove number codes completely from the local end.

Comment 1

[Andreas Tolfsen ❲:ato❳]

https://github.com/mozilla-b2g/marionette-js-client/pull/135

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Attachment: marionette-js-client pull request

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8592203 [details] [review]
marionette-js-client pull request

Will land once you squash your commits. Nice job!

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Landed on mozilla-b2g/marionette-js-client master https://github.com/mozilla-b2g/marionette-js-client/commit/20ad50386da376c3ab1dc69f1fe5311a472911bc

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] gaye:marionette-client-1.7.3 > mozilla-b2g:master

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1150523 > mozilla-b2g:master

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/5204ebbc0e67d15d98ffb962fa2a9ad1e3bb42f6 landed on gaia master