Closed Bug 1150527 Opened 5 years ago Closed 4 years ago

Remove number based error lookup from Marionette Python client

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox-esr52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox-esr52 --- fixed
firefox53 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

(Keywords: pi-marionette-client)

Attachments

(2 files)

Once and bug 1150522 and bug 945729 are fixed, we should remove support for lookup of errors by number.
Depends on: 945729, 1150522
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8811330 [details]
Bug 1150527 - Remove error numbers from Marionette Python client;

https://reviewboard.mozilla.org/r/93486/#review93824

::: testing/marionette/client/marionette_driver/errors.py:160
(Diff revision 2)
>  class UnsupportedOperationException(MarionetteException):
> -    code = (405,)
>      status = "unsupported operation"
>  
>  
> -es_ = [e for e in locals().values() if type(e) == type and issubclass(e, MarionetteException)]
> +es_ = [e for e in locals().values() if type(

I find this harder to read now, can you put it back to 1 line
Attachment #8811330 - Flags: review?(dburns) → review+
Comment on attachment 8811331 [details]
Bug 1150527 - Remove unusued InstallGeckoError type;

https://reviewboard.mozilla.org/r/93488/#review93826
Attachment #8811331 - Flags: review?(dburns) → review+
Comment on attachment 8811330 [details]
Bug 1150527 - Remove error numbers from Marionette Python client;

https://reviewboard.mozilla.org/r/93486/#review93824

> I find this harder to read now, can you put it back to 1 line

Sorry, I agree.  Sideeffect of running it through autopep8.
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c80303bb0436
Remove error numbers from Marionette Python client; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/5cdaf32224f5
Remove unusued InstallGeckoError type; r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/c80303bb0436
https://hg.mozilla.org/mozilla-central/rev/5cdaf32224f5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Nothing speaks against uplifting this patch to esr52. The referenced dependencies in comment 0 are both fixed in Firefox 40. So this test-only patch should be fine for esr52.
Whiteboard: [checkin-needed-esr52]
You need to log in before you can comment on or make changes to this bug.