1150555 - Negative values and stuck add-ons in about:performance

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Sometimes, we see negative durations and add-ons that remain on display although they should have disappeared. I'm almost sure that this is due to us using key `component.name`, which has the same value for all Jetpack add-ons.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Let's use both the addonId and the compartment name as key

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85cd93a6a6f2

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8587455 [details] [diff] [review]
Let's use both the addonId and the compartment name as key

Review of attachment 8587455 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/aboutperformance/content/aboutPerformance.js
@@ +54,5 @@
>      let newData = new Map();
>      let deltas = [];
>      for (let componentNew of snapshot.componentsData) {
> +      let {name, addonId, isSystem} = componentNew;
> +      let key = `{name: ${name}, addonId: ${addonId}, isSystem: ${isSystem}}`;

Might be cleaner to just do JSON.stringify({ name, addonId, isSystem });

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Let's use both the addonId and the compartment name as key, v2

Applied feedback.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d868eb0199f7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/65cf17c1b942

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/65cf17c1b942