Closed Bug 1150555 Opened 9 years ago Closed 9 years ago

Negative values and stuck add-ons in about:performance

Categories

(Toolkit :: Performance Monitoring, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(1 file, 1 obsolete file)

Sometimes, we see negative durations and add-ons that remain on display although they should have disappeared. I'm almost sure that this is due to us using key `component.name`, which has the same value for all Jetpack add-ons.
Assignee: nobody → dteller
Attachment #8587455 - Flags: review?(dtownsend)
Comment on attachment 8587455 [details] [diff] [review]
Let's use both the addonId and the compartment name as key

Review of attachment 8587455 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/aboutperformance/content/aboutPerformance.js
@@ +54,5 @@
>      let newData = new Map();
>      let deltas = [];
>      for (let componentNew of snapshot.componentsData) {
> +      let {name, addonId, isSystem} = componentNew;
> +      let key = `{name: ${name}, addonId: ${addonId}, isSystem: ${isSystem}}`;

Might be cleaner to just do JSON.stringify({ name, addonId, isSystem });
Attachment #8587455 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/65cf17c1b942
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.