Closed
Bug 1150555
Opened 9 years ago
Closed 9 years ago
Negative values and stuck add-ons in about:performance
Categories
(Toolkit :: Performance Monitoring, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 1 obsolete file)
1.54 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
Sometimes, we see negative durations and add-ons that remain on display although they should have disappeared. I'm almost sure that this is due to us using key `component.name`, which has the same value for all Jetpack add-ons.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → dteller
Attachment #8587455 -
Flags: review?(dtownsend)
Assignee | ||
Comment 2•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85cd93a6a6f2
Comment 3•9 years ago
|
||
Comment on attachment 8587455 [details] [diff] [review] Let's use both the addonId and the compartment name as key Review of attachment 8587455 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/aboutperformance/content/aboutPerformance.js @@ +54,5 @@ > let newData = new Map(); > let deltas = []; > for (let componentNew of snapshot.componentsData) { > + let {name, addonId, isSystem} = componentNew; > + let key = `{name: ${name}, addonId: ${addonId}, isSystem: ${isSystem}}`; Might be cleaner to just do JSON.stringify({ name, addonId, isSystem });
Attachment #8587455 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Applied feedback. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d868eb0199f7
Attachment #8587455 -
Attachment is obsolete: true
Attachment #8587669 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/65cf17c1b942
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65cf17c1b942
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•