1150570 - [Search] Stuck on the search provider screen after pulling down utility tray

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Search something in the rocketbar
2.- Click on the search provider
3.- When the selector is displayed, pull down the utility tray
4.- Click again on the rocketbar

Expected:

The provider selector has been closed or, at least, the keyboard is not shown

Actual:

The provider selector menu is still there, and the keyboard doesn't allow to clik OK

Comment 1

[Alberto Pastor [:albertopq]]

I thought this issue would be fixed by bug 1150424, but I noticed they are actually 2 different problems, and I would say that this one is a blocker. Kevin, I won't have time to take it. Do you have bandwidth?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1150570_publish_search_window_closing > mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8588276 [details] [review]
[gaia] KevinGrandon:bug_1150570_publish_search_window_closing > mozilla-b2g:master

Hey Alive - could you take a look at this if you have a chance? It appears that the search app was never firing a `closing` event. If we fire this from rocketbar, ValueSelector will receive it and close the selector. What do you think?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8588276 [details] [review]
[gaia] KevinGrandon:bug_1150570_publish_search_window_closing > mozilla-b2g:master

I somewhat dislike the manager does the favor for the instance for what it should do... could we just publish another event here?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Kevin Grandon :kgrandon from comment #3)
> Comment on attachment 8588276 [details] [review]
> [gaia] KevinGrandon:bug_1150570_publish_search_window_closing >
> mozilla-b2g:master
> 
> Hey Alive - could you take a look at this if you have a chance? It appears
> that the search app was never firing a `closing` event. If we fire this from
> rocketbar, ValueSelector will receive it and close the selector. What do you
> think?

Good investigation. No closing event is correct - it is because rocketbar has 'immediate' transition so it will just go from the opened state to the closed state.
So since the problem is ValueSelector needs closing event, I think the solution here is adding 'closed' event in ValueSelector. Could you try with this? Thanks!

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1150570_value_selector_closed_evt > mozilla-b2g:master

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8588620 [details] [review]
[gaia] KevinGrandon:bug_1150570_value_selector_closed_evt > mozilla-b2g:master

Hey Alive - new patch here, seems to work just as well. Please take a look if you have time, thanks!

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8588620 [details] [review]
[gaia] KevinGrandon:bug_1150570_value_selector_closed_evt > mozilla-b2g:master

Nice, thanks!

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/16500ba97439340b253fbc17a31cefa938f48ea5

Comment 10

[Hermes Cheng (inactive after July 27, 2015)]

Since it is a 2.2 blocker, please uplift to 2.2. Thanks. ;)

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8588620 [details] [review]
[gaia] KevinGrandon:bug_1150570_value_selector_closed_evt > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Poor UX when using rocketbar features.
[Testing completed]: Manual and unit testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, small contained patch.
[String changes made]: None.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/6e65f9ec7cb46ff0cfebd98122dd0245899882c5

Comment 13

[Hermes Cheng (inactive after July 27, 2015)]

verified with below test env...
*v2.2
Build ID               20150416162504
Gaia Revision          d50b8a3919a7b4d8d289f150d3b9bed704ebafa9
Gaia Date              2015-04-16 21:46:57
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5ebf32030512
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.195720
Firmware Date          Thu Apr 16 19:57:29 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150416160206
Gaia Revision          3cd0a9facce26c2acc7be3755a17131a6358e33f
Gaia Date              2015-04-16 16:33:22
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/51e3cb11a258
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.191700
Firmware Date          Thu Apr 16 19:17:10 EDT 2015
Bootloader             L1TC000118D0