1150703 - Add a flag to prevent content-privileged about URIs from being linked to

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[:Gijs (out for now; he/him)]

See bug 1147597 for context.

Basically, right now about: pages can pick between being privileged or being linked to. Sometimes they want neither. We should add a flag that can be used in conjunction with SAFE_FOR_UNTRUSTED_CONTENT to achieve this.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Makes sense to me.

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Patch v0.1

I don't know if/how it's possible to write a test for this, but as this is sec-sensitive it should probably be another patch anyway.

Also, accepting suggestions for a better name for this flag if people think that's necessary.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Thanks for taking this Gijs. Best to move the browser/components changes to bug 1150862, I think.

Comment 5

[:Gijs (out for now; he/him)]

Attachment: Patch v0.2

Comment 6

[:Gijs (out for now; he/him)]

Comment on attachment 8588037 [details] [diff] [review]
Patch v0.2

A little bird tells me sworkman isn't around at the moment... Patrick/Jonas, can you help?

Comment 7

[:Gijs (out for now; he/him)]

Going to assume this is sec-want as well per bug 1150862.

Comment 8

[Patrick McManus [:mcmanus]]

Comment on attachment 8588037 [details] [diff] [review]
Patch v0.2

Review of attachment 8588037 [details] [diff] [review]:
-----------------------------------------------------------------

I apologize for the delay - I was hoping someone more familiar with your project would step up.. I did my best and this makes sense to me.

::: netwerk/protocol/about/nsAboutProtocolHandler.cpp
@@ +33,5 @@
> +  uint32_t flags;
> +  nsresult rv = aModule->GetURIFlags(aURI, &flags);
> +  NS_ENSURE_SUCCESS(rv, false);
> +
> +  return (flags & nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT) != 0 && (flags & nsIAboutModule::MAKE_UNLINKABLE) == 0;

nit.. iirc the styleguide discourages comparing against null or 0.. so just
return (one) && !(two)

Comment 9

[:Gijs (out for now; he/him)]

w/ nit:

remote:   https://hg.mozilla.org/integration/fx-team/rev/e416125133da

Comment 10

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/e416125133da

Comment 11

[:Gijs (out for now; he/him)]

Comment on attachment 8588037 [details] [diff] [review]
Patch v0.2

Approval Request Comment:
[Feature/regressing bug #]: Reader mode is safer with this.
[User impact if declined]: content pages can link to reader mode which is a Bad Idea (defense in depth)
[Describe test coverage new/current, TreeHerder]: nope :-(
[Risks and why]: pretty low
[String/UUID change made/needed]: no; there's an IDL adjustment but it's only an added flag which is defined on the IDL and therefore doesn't need UUID adjustment nor does it change binary compat, AIUI.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Should be in 38 beta 5.

Comment 13

[:Gijs (out for now; he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/cde24f75ddb0

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/5c9df6adebed