1150802 - [Flame][Dialer] Extra buttons are displayed on the known and unknown contact's call information views.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Shine(Leave from Mozilla)]

[1.Description]:
[Flame][v2.2& v3.0][Dialer]Launch Dialer and make an known call and an unknown call, on an known contact's call information screen, the "Add to existing contact" and "Create new contact" buttons will be displayed. On an unknown contact's call information screen, the "Contact details"  button will be displayed.
See attachment: logcat_1500.txt & Video2.MP4
Found at: 15:00

[2.Testing Steps]: 
1. Launch Phone app and enter Dialer view.
2. Make an known call.
3. Make an unknown call.
4.Switch to Call log view.
5. Long Press the known call and select "Call Information".
6. Long Press the unknown call and select "Call Information".

[3.Expected Result]: 
5. The "Add to existing contact" and "Create new contact" buttons could not be displayed.
6. The "Contact details" button could not be displayed.

[4.Actual Result]: 
5. The "Add to existing contact" and "Create new contact" buttons will be displayed.
6. The "Contact details"  will be displayed.

[5.Reproduction build]: 
Device: Flame 2.1 (Unaffected)
Build ID               20150402161201
Gaia Revision          4e7d880defb83c25b49462479c02b3e64d21f421
Gaia Date              2015-04-02 18:26:54
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/e76f5e7a264d
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.194043
Firmware Date          Thu Apr  2 19:40:52 EDT 2015
Bootloader             L1TC000118D0

Flame 2.2 (Affected)
Build ID               20150402002500
Gaia Revision          1ceca464053dee4a8bf10ea5abeef724d68c2ff2
Gaia Date              2015-04-01 09:49:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/427b4da96714
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.035057
Firmware Date          Thu Apr  2 03:51:09 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 (Affected)
Build ID               20150402160202
Gaia Revision          62042ffcc8c6cca0f51ad23f5c2b979fc153b5a7
Gaia Date              2015-04-02 16:01:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/513265a4cbc2
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.192125
Firmware Date          Thu Apr  2 19:21:37 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
This problem cannot be reproduced on Flame2.1.

Comment 1

[Shine(Leave from Mozilla)]

Attachment: logcat_1500.txt

Comment 2

[Shine(Leave from Mozilla)]

Attachment: Video2.MP4

Comment 3

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Broken functionality on a standard use case.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Note: I repro'd this issue on the latest master with regular phone numbers.

Comment 5

[Doug Sherk (:drs) (inactive)]

Caused by bug 1139179.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] DouglasSherk:1150802-call-info-buttons-extra > mozilla-b2g:master

Comment 7

[Doug Sherk (:drs) (inactive)]

Whoops.

Comment 8

[Doug Sherk (:drs) (inactive)]

Attachment: Fix extra call info buttons being displayed due to `display` property overriding `hidden` attribute.

Comment 9

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8587986 [details] [diff] [review]
Fix extra call info buttons being displayed due to `display` property overriding `hidden` attribute.

Johan, could you verify this before we land it?

Comment 10

[Tamara Hills [:thills]]

Comment on attachment 8587986 [details] [diff] [review]
Fix extra call info buttons being displayed due to `display` property overriding `hidden` attribute.

Hi Doug,

It looks good and fixes it for me.  I tested out bug 1139179 as well and I didn't see any obvious breakages of that fix due to this change.

Thanks,
-tamara

Comment 11

[Peter Bylenga [:PBylenga]]

qawanted to test around the gaia patch.

Comment 12

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8587986 [details] [diff] [review]
Fix extra call info buttons being displayed due to `display` property overriding `hidden` attribute.

Sorry, I won't have time to test it before FC. The QAnalysts are on it per comment 11.

Comment 13

[Yeojin Chung [:YeojinC]]

Attachment: PatchApplied.png

The issue no longer occurs after the patch is applied to the latest Flame 3.0. With a known contact, "Contact details" button appears. With a unknown contact, "Add to existing contact" and "Create new contact" buttons appear. No issue has been found with the patch.

Comment 14

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8587986 [details] [diff] [review]
Fix extra call info buttons being displayed due to `display` property overriding `hidden` attribute.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1139179
[User impact] if declined: All contact buttons in Dialer call info page will always appear, regardless of whether a call is associated with a contact or not.
[Testing completed]: Tamara, Yeojin, and I all tested this.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/98c2db0a62778804567ce7d08f921b409f375655

Comment 16

[KTucker [:KTucker][Inactive 3/4/2016]]

Please verify this again on Monday Yeojin.

Comment 17

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: With a known contact, "Contact details" button appears. With a unknown contact, "Add to existing contact" and "Create new contact" buttons appear.

Environmental Variables:
Device: Flame 3.0 (KK, 319mb, full flash)
Build ID: 20150406010204
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 4fe763cbe196
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

=======================================
Leaving verifyme for Flame 2.2 uplift & verification.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/14edb36efe16e7cecf5ba063eaef8fc9c62d8f9c

Comment 19

[Shine(Leave from Mozilla)]

Attachment: Verify_screenshot.png

This problem is verified pass on latest build of Flame2.2 by the STR in comment 0.
Actual result: On a known contact call information view, the "Contact details" button is displayed. On an unknown contact call information view, "Add to existing contact" and "Create new contact" buttons are displayed.
See attachment: Verify_screenshot.png
Rate: 0/5

Device: Flame 2.2(Pass)
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.195227
Firmware Date          Tue Apr  7 19:52:39 EDT 2015
Bootloader             L1TC000118D0