1150855 - Method definitions require curly brackets

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

I blame FunctionType vs FunctionSyntaxKind, we really need to unify those!

This is not valid in ES6: var o = {x() 12};

Comment 1

[Tom S [:evilpie]]

Attachment: Disallow method syntax without curly brackets

Comment 2

[Tom S [:evilpie]]

Attachment: Fix some trivial uses in browser and toolkit

We also need to wait for https://github.com/mozilla/addon-sdk/pull/1973 to merge.

Comment 3

[Eric Faust [:efaust]]

Comment on attachment 8607576 [details] [diff] [review]
Disallow method syntax without curly brackets

Review of attachment 8607576 [details] [diff] [review]:
-----------------------------------------------------------------

Wfm. We should address getters and setters in some way.

::: js/src/frontend/Parser.cpp
@@ +2563,5 @@
>      TokenKind tt;
>      if (!tokenStream.getToken(&tt, TokenStream::Operand))
>          return false;
>      if (tt != TOK_LC) {
> +        if (funbox->isStarGenerator() || kind == Method || kind == ClassConstructor) {

This should also include kind == Getter && kind == Setter, but my understanding is that this will be a lot more painful to update our code to be compliant with that. We still need to do that, though. Can we leave-open this bug, or file a followup to handle that?

::: js/src/tests/js1_8_5/reflect-parse/methodDefn.js
@@ +12,5 @@
>  
> +// Method definitions without braces
> +assertError("({ a() void 0 })", SyntaxError);
> +assertError("({ a() 1 })", SyntaxError);
> +assertError("({ a() false })", SyntaxError);

Can we test this in classes as well?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf58656d6fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/0135ea20609a

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6cf58656d6fb
https://hg.mozilla.org/mozilla-central/rev/0135ea20609a

Comment 6

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions#SpiderMonkey-specific_notes
https://developer.mozilla.org/en-US/Firefox/Releases/41#JavaScript

Leaving ddn open for Kohei/site-compat for now.

Comment 7

[Florian Scholz (Open Web Docs)]

> Leaving ddn open for Kohei/site-compat for now.
https://developer.mozilla.org/en-US/Firefox/Releases/41/Site_Compatibility#JavaScript