Capitalize all thNotify.send() messages

RESOLVED FIXED

Status

Tree Management
Treeherder
P5
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfrench, Assigned: Tapesh Mandal, Mentored)

Tracking

Details

(Whiteboard: [good first bug][lang=js], URL)

User Story

Thank you for helping out with Treeherder!

You can find us on IRC at irc://irc.mozilla.org/treeherder

Here's some links to help get you started.

Project page:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder

Repo locations and links to set up a development version of the software:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Getting_Started

Interacting with us:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing

A-Team general reference, coding style guides:
http://ateam-bootcamp.readthedocs.org

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Per one of Ed's review comments in PR449, we'd like to capitalize all thNotify.send() messages, as some are not, for example in the pinboard and pinboard services. 


https://github.com/mozilla/treeherder-ui/search?p=1&q=thNotify.send&utf8=%E2%9C%93

I will put this up as a good first bug for tapesh in channel.
(Reporter)

Updated

3 years ago
User Story: (updated)
(Reporter)

Updated

3 years ago
Assignee: nobody → tapesh.mandal
Status: NEW → ASSIGNED

Updated

3 years ago
Whiteboard: [good first bug] → [good first bug][lang=js]
(Assignee)

Comment 1

3 years ago
Created attachment 8589870 [details] [review]
pull request for bug 1150938
Attachment #8589870 - Flags: review?(wlachance)
Comment on attachment 8589870 [details] [review]
pull request for bug 1150938

lgtm, thanks!
Attachment #8589870 - Flags: review?(wlachance) → review+

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/e65d12ce7b1e2497ded6fd856d409b090e1097df
Bug 1150938 - Capitalize all thNotify.send() messages

https://github.com/mozilla/treeherder-ui/commit/bb02c70a89be2ddae6cfdc19208d42d6d716f9b7
Merge pull request #456 from mandaltapesh/tree-ui-moz-bug-1150938

Bug 1150938 - Capitalize all thNotify.send() messages
Pretty sure we can resolve this bug now. Thanks to all involved. :)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b81d6ce4d49186d3342e206a6f9be48a04a09521
Bug 1150938 - Capitalize all thNotify.send() messages

https://github.com/mozilla/treeherder/commit/0b9bcbdad7b866fff55810ec0e9307a9656f6b15
Merge pull request #456 from mandaltapesh/tree-ui-moz-bug-1150938

Bug 1150938 - Capitalize all thNotify.send() messages
You need to log in before you can comment on or make changes to this bug.