1150946 - Relabel Service Workers toolbox option

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1003991 added a new toolbox option:

"Enable Service Workers testing features"

From the bug, it allows you to use them over http instead of requiring https, but that is not all clear from the name.

At the very least, we should document the meaning, but should we re-label the option too?

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

José, are the plans to put other Service Worker developer features behind the same flag, or will it remain as just allowing them over HTTP?

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to J. Ryan Stinnett [:jryans] from comment #1)
> José, are the plans to put other Service Worker developer features behind
> the same flag, or will it remain as just allowing them over HTTP?

No, there aren't AFAIK. We should re-label the option. Do you want me to do it? I could add some doc if you want to make things clearer. Sorry. Thanks!

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> (In reply to J. Ryan Stinnett [:jryans] from comment #1)
> > José, are the plans to put other Service Worker developer features behind
> > the same flag, or will it remain as just allowing them over HTTP?
> 
> No, there aren't AFAIK. We should re-label the option. Do you want me to do
> it? I could add some doc if you want to make things clearer. Sorry. Thanks!

It would be great to re-label it something like "Enable Service Workers over HTTP (when toolbox is open)".  Also, updating the options docs[1] would be great, but we can also set "dev-doc-needed" here to have them updated by MDN Docs team.

If you're able to make the label change, that would be great!

[1]: https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox#Settings

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

This patch changes the label to "Enable Service Workers over HTTP (when toolbox is open)". Once it lands I'll add some doc in MDN.

Nikhil, are you also ok with this change?

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8589116 [details] [diff] [review]
v1

:jryans, could you have a look as well please? Thanks!

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8589116 [details] [diff] [review]
v1

Review of attachment 8589116 [details] [diff] [review]:
-----------------------------------------------------------------

Text changes look great to me, but you'll need to change the string IDs so the l10n team can pick it up[1], and then update the files where they are referenced.

Maybe replace "enableServiceWorkersTesting" with "enableServiceWorkersHTTP"?  Up to you, as long they change! :)

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v2

Addressees review comments made at comment 6.

Carrying out r=nsm,jryans

Try results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=f583a4dc70bc

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Try looks good, lets land this then. Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2a3a0ee67d05

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a3a0ee67d05

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Doc added at https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox. Thanks!