Closed Bug 1150978 Opened 7 years ago Closed 7 years ago

Telemetry has constants for datareporting.healthreport.uploadEnabled but they are never used

Categories

(Toolkit :: Telemetry, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: benjamin, Unassigned)

References

Details

In both TelemetryPing and TelemetrySession there are 

const PREF_FHR_UPLOAD_ENABLED = "datareporting.healthreport.uploadEnabled";

These prefs are never used. I'm pretty sure the bug is that this prefs should be used in TelemetryPing: this pref represents the checkbox in prefs for disabling sending FHR and telemetry.
This will also fix problems where xpcshell tests are calling TelemetryPing.send and crashing: the uploadEnabled pref should be missing/false in the normal xpcshell environment.
Blocks: 1121013
Alessio, is that something that will get cleared up by bug 1134279?
Flags: needinfo?(alessio.placitelli)
That's something being done in bug 1137252 (|_canSend|).
Flags: needinfo?(alessio.placitelli)
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> This will also fix problems where xpcshell tests are calling
> TelemetryPing.send and crashing: the uploadEnabled pref should be
> missing/false in the normal xpcshell environment.

What is the crash here? Is it for outbound network traffic in tests?

If so, we should just set this to a proper dummy URL in test profiles that doesn't trigger this.
Flags: needinfo?(benjamin)
(In reply to Georg Fritzsche [:gfritzsche] from comment #4)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> > This will also fix problems where xpcshell tests are calling
> > TelemetryPing.send and crashing: the uploadEnabled pref should be
> > missing/false in the normal xpcshell environment.
> 
> What is the crash here? Is it for outbound network traffic in tests?
> 
> If so, we should just set this to a proper dummy URL in test profiles that
> doesn't trigger this.

... which bug 1137252 apparently takes care off too.
(In reply to Georg Fritzsche [:gfritzsche] from comment #5)
> (In reply to Georg Fritzsche [:gfritzsche] from comment #4)
> > (In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> > > This will also fix problems where xpcshell tests are calling
> > > TelemetryPing.send and crashing: the uploadEnabled pref should be
> > > missing/false in the normal xpcshell environment.
> > 
> > What is the crash here? Is it for outbound network traffic in tests?
> > 
> > If so, we should just set this to a proper dummy URL in test profiles that
> > doesn't trigger this.
> 
> ... which bug 1137252 apparently takes care off too.

Bug 1137252 didn't actually handle this for xpcshell, but i ran into this in bug 1150134 and am fixing it there.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(benjamin)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.