Closed Bug 1151034 Opened 10 years ago Closed 10 years ago

Wildly wrong line numbers in search results

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox40 --- affected

People

(Reporter: erik, Assigned: erik)

References

Details

Search for https://dxr.allizom.org/mozilla-central/search?q=%2Bvar-ref%3A%22GetAccessibleWrap%28AtkObject+*%29%3A%3AaAtkObj%22. Among the results is... 1031 reinterpret_cast<AccessibleWrap*>(MAI_ATK_OBJECT(aAtkObj)->accWrap); Click it. Line 1031 has nothing on it but a lone "}". That line is actually line 45. Whaaaa?
Blocks: 1127125
Assignee: nobody → erik
It looks like something is wrong with the line sorting when displaying files. All the lines are there in https://dxr.allizom.org/mozilla-central/source/accessible/atk/DocAccessibleWrap.cpp, for instance, but they're in the wrong order.
Commit pushed to es at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/4b5cb03df4804cde25a27a54dc7c83c3b023bbb9 Sort lines when displaying files. Fixes bug 1151034. We just weren't sorting at all. Oops! Though we were getting lucky locally, the production cluster doesn't always return things in order.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.