Closed Bug 1151111 Opened 10 years ago Closed 10 years ago

Intermittent test_browserElement_oop_XFrameOptionsAllowFrom.html | uncaught exception - TypeError: invalid arguments at browserElement_XFrameOptionsAllowFrom.js:15

Categories

(Core :: DOM: Content Processes, defect)

Product:
Core
Component:
DOM: Content Processes
Version:
39 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox38 --- wontfix
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: KWierso, Assigned: mtseng)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

Append iframe2 after iframe1 has loaded v2. (carry r+: kanru)
1.46 KB, patch
Details | Diff | Splinter Review
10:44:53 INFO - 1601 INFO TEST-START | dom/browser-element/mochitest/test_browserElement_oop_XFrameOptionsAllowFrom.html 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://example.org/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://example.com/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test1.example.org/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test1.example.org:8000/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://sub1.test1.example.org/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://example.com/manifest_priv.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://example.com/manifest_cert.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://example.com/manifest_csp_cert.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://example.com/manifest_csp_inst.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://example.com/manifest_csp_priv.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://acertified.com/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://aprivileged.com/manifest.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://127.0.0.1:8888/sample.manifest 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://127.0.0.1:8888/sample.manifest 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_reviewers_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/marketplace/marketplace_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/marketplace/marketplace_privileged_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/marketplace/marketplace_reviewers_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_dev_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_dev_privileged_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_dev_reviewers_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace-dev.allizom.org/tests/dom/apps/tests/marketplace/marketplace_dev_reviewers_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_stage_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_stage_privileged_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages https://marketplace.firefox.com/tests/dom/apps/tests/marketplace/marketplace_stage_reviewers_app.webapp 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test/tests/dom/apps/tests/file_packaged_app.sjs?getManifest=true 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test/tests/dom/apps/tests/file_packaged_app.sjs?getManifest=true&allowCancel 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test/tests/dom/apps/tests/file_packaged_app.sjs?getManifest=true&appToUpdate&testNameChange 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test/tests/dom/apps/tests/file_packaged_app.sjs?getManifest=true&appName=arandomname&appToFail1 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/signed_app.sjs?app=corrupt&version=1 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/signed_app.sjs?app=unknown_issuer&version=1 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/signed_app.sjs?app=origin&version=1 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://mochi.test:8888/tests/dom/apps/tests/signed_app.sjs?app=valid&version=1 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - -*-*- Langpacks: getAdditionalLanguages http://test/tests/dom/apps/tests/file_packaged_app.sjs?getManifest=true&test_role 10:44:53 INFO - -*-*- Langpacks: Languages found: ({langs:{}}) 10:44:53 INFO - ############################### browserElementPanningAPZDisabled.js loaded 10:44:53 INFO - ############################### browserElementPanning.js loaded 10:44:53 INFO - ######################## BrowserElementChildPreload.js loaded 10:44:53 INFO - 1602 INFO TEST-UNEXPECTED-FAIL | dom/browser-element/mochitest/test_browserElement_oop_XFrameOptionsAllowFrom.html | uncaught exception - TypeError: invalid arguments at http://mochi.test:8888/tests/dom/browser-element/mochitest/browserElement_XFrameOptionsAllowFrom.js:15 10:44:53 INFO - JavaScript error: http://mochi.test:8888/tests/dom/browser-element/mochitest/browserElement_XFrameOptionsAllowFrom.js, line 15: TypeError: invalid arguments 10:44:53 INFO - 1603 INFO MEMORY STAT vsize after test: 909053952 10:44:53 INFO - 1604 INFO MEMORY STAT vsizeMaxContiguous after test: 633536512 10:44:53 INFO - 1605 INFO MEMORY STAT residentFast after test: 268009472 10:44:53 INFO - 1606 INFO MEMORY STAT heapAllocated after test: 58597276 10:44:53 INFO - 1607 INFO TEST-OK | dom/browser-element/mochitest/test_browserElement_oop_XFrameOptionsAllowFrom.html | took 437ms 10:44:53 INFO - 1608 INFO TEST-START | dom/browser-element/mochitest/test_browserElement_oop_XFrameOptionsDeny.html
Morris, would you be interested in looking at this one?
Component: Security → DOM: Content Processes
Flags: needinfo?(mtseng)
I guess this test failed because we catch the "load" event when iframe2 append to document and loading a blanking page instead of "load" event generating by changing iframe2.src. So I defer addEventListener for iframe2 and hope it catch right callback in the future. But I'm not sure my guessing is right, :kanru, what do you think?
Attachment #8599152 - Flags: review?(kchen)
Working on it.(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #14) > Morris, would you be interested in looking at this one? Working on it.
Assignee: nobody → mtseng
Status: NEW → ASSIGNED
Flags: needinfo?(mtseng)
Comment on attachment 8599152 [details] [diff] [review] Add 'load' event listener after iframe2.src is changed. Review of attachment 8599152 [details] [diff] [review]: ----------------------------------------------------------------- Do you have to append iframe1 and iframe2 at the same time? Could you set iframe2.src and append it it the iframe1 load EventHandler?
Addressed kanru's comment.
Attachment #8599152 - Attachment is obsolete: true
Attachment #8599152 - Flags: review?(kchen)
Attachment #8600772 - Flags: review?(kchen)
Comment on attachment 8600772 [details] [diff] [review] Append iframe2 after iframe1 has loaded. Review of attachment 8600772 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/browser-element/mochitest/file_browserElement_XFrameOptionsAllowFrom.html @@ +30,5 @@ > iframe2Loaded = true; > alert('finish'); > }); > > + setTimeout(function() { This setTimeout is unnecessary.
Attachment #8600772 - Flags: review?(kchen) → review+
looks great.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0376b1ce88bc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: