115113 - de-comify nsHTMLReflowCommand

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Chris Waterson]

There is no reason to have nsIReflowCommand, since this class is not used
outside the layout engine. I'd also like to eliminate the interface class so I
could mutate the reflow command directly (see

  <http://bugzilla.mozilla.org/show_bug.cgi?id=91423#c38>).

Comment 1

[Chris Waterson]

Attachment: remove nsIReflowCommand.h, fix users to use nsHTMLReflowCommand directly

Pretty rote. The only interesting changes are in:

. nsHTMLReflowCommand.h, where I added the doc-comments from nsIReflowCommand,
  and de-virtualized all the methods.

. nsPresShell.cpp, which now assumes direct ownership of reflow commands once
  appended to the queue.

. nsBlockFrame.cpp, which adds some debugging stuff that I had sitting around
  in my tree.

Since nsHTMLReflowCommand is no longer an nsIReflowCommand (and hence no longer
an nsISupports), places that had addressed it with a comptr now use a bare
pointer instead.

Comment 2

[karnaze (gone)]

Comment on attachment 61632 [details] [diff] [review]
remove nsIReflowCommand.h, fix users to use nsHTMLReflowCommand directly

r=karnaze

Comment 3

[Chris Waterson]

Attachment: patch that compiles outside the mozilla/layout directory

Oops. I jumped the gun: Several files outside the layout directory included
nsIPresShell or nsHTMLParts.h, which meant that they couldn't see
nsHTMLReflowCommand.h header.

They don't really _need_ to see the nsHTMLReflowCommand class, so I've just
added an anonymous

  class nsHTMLReflowCommand;

declaration; however, you can't have anonymous enum declarations, so I broke
the reflow types out into nsReflowType.h, and exported it.

Still look okay?

Comment 4

[karnaze (gone)]

Comment on attachment 61754 [details] [diff] [review]
patch that compiles outside the mozilla/layout directory

It looks like only nsIPresShell::CancelReflowCommand bit you. r=karnaze

Comment 5

[Marc Attinasi]

Comment on attachment 61754 [details] [diff] [review]
patch that compiles outside the mozilla/layout directory

NITS:
* spacing not lining up on 
+	 nsReflowType.h 		 

* does nsReflowType.h need a newline at the end of the file?

otherwise, looks great, much better this way. sr=attinasi

Comment 6

[Chris Waterson]

Thanks: fixed those problems in my tree. I'll check it in when mozilla-0.9.8 opens.

Comment 7

[Chris Waterson]

Checked in.