1151145 - Scrolling on MDN's page on the transform property produces visual corruption

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Attachment: Screen Shot 2015-04-03 at 5.42.07 PM.png

STR: Visit this page:

https://developer.mozilla.org/en-US/docs/Web/CSS/transform

and scroll around.

I get lots of boxes that are black or contain the wrong textures on OS X Nightly.

An example is attached.

Comment 1

[Markus Stange [:mstange]]

[Tracking Requested - why for this release]: Bad regression from bug 1123019, might also be responsible for the other "gray rectangle" bugs we've seen around

Comment 2

[Markus Stange [:mstange]]

Attachment: MozReview Request: bz://1151145/mstange

/r/6641 - Bug 1151145 - Make sure we don't call CGContextSaveGState without calling CGContextRestoreGState in DrawTargetCG::StrokeRect. r=jrmuizel
/r/6643 - Bug 1151145 - Add assertions to detect unbalanced calls to CGContextSaveGState / CGContextRestoreGState. r=jrmuizel
/r/6645 - Bug 1151145 - Add a reftest. r=jrmuizel

Pull down these commits:

hg pull -r 217cae83dc010f3bc76019873a382df62f38b3b9 https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

https://reviewboard.mozilla.org/r/6645/#review5511

Ship It!

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/852527d009a4
https://hg.mozilla.org/integration/mozilla-inbound/rev/135120efabd3
https://hg.mozilla.org/integration/mozilla-inbound/rev/92b866002a30

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8588369 [details]
MozReview Request: bz://1151145/mstange

Approval Request Comment
[Feature/regressing bug #]: bug 1123019
[User impact if declined]: drawing corruption
[Describe test coverage new/current, TreeHerder]: this patch adds a test
[Risks and why]: extremely low
[String/UUID change made/needed]: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/852527d009a4
https://hg.mozilla.org/mozilla-central/rev/135120efabd3
https://hg.mozilla.org/mozilla-central/rev/92b866002a30

Comment 7

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8588369 [details]
MozReview Request: bz://1151145/mstange

Approved for uplift to aurora, low risk, includes tests.

Comment 8

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Since this fixes a regression I'd like us to get QE verification on this fix (on Nightly and Aurora). Florin is this something your team can take on? Thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c4248bd6b7c3
https://hg.mozilla.org/releases/mozilla-aurora/rev/969ad710b89e
https://hg.mozilla.org/releases/mozilla-aurora/rev/77b9d633dfb9

Comment 10

[Cornel Ionce [:noni]]

Reproduced this issue on Mac OS X 10.9.5 using 2015-04-03 Nightly.

Confirming the fix on Mac OS X 10.9.5, Windows 7 64-bit and Ubuntu 12.04 32-bit using:
- latest Nightly, build ID: 20150416030209.
- latest Aurora, build ID: 20150416004008.

Comment 12

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1151145 - Make sure we don't call CGContextSaveGState without calling CGContextRestoreGState in DrawTargetCG::StrokeRect. r=jrmuizel

Comment 13

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1151145 - Add assertions to detect unbalanced calls to CGContextSaveGState / CGContextRestoreGState. r=jrmuizel

Comment 14

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1151145 - Add a reftest. r=jrmuizel