Scrolling on MDN's page on the transform property produces visual corruption

VERIFIED FIXED in Firefox 39

Status

()

Core
Graphics: Layers
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: seth, Assigned: mstange)

Tracking

({regression})

unspecified
mozilla40
regression
Points:
---
Bug Flags:
in-testsuite +
qe-verify +

Firefox Tracking Flags

(firefox37 unaffected, firefox38 unaffected, firefox39+ verified, firefox40 verified)

Details

(Whiteboard: gfx-noted)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8588247 [details]
Screen Shot 2015-04-03 at 5.42.07 PM.png

STR: Visit this page:

https://developer.mozilla.org/en-US/docs/Web/CSS/transform

and scroll around.

I get lots of boxes that are black or contain the wrong textures on OS X Nightly.

An example is attached.
Whiteboard: gfx-noted
(Assignee)

Updated

3 years ago
Assignee: nobody → mstange
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
[Tracking Requested - why for this release]: Bad regression from bug 1123019, might also be responsible for the other "gray rectangle" bugs we've seen around
Blocks: 1123019
status-firefox37: --- → unaffected
status-firefox38: --- → unaffected
status-firefox39: --- → affected
status-firefox40: --- → affected
tracking-firefox39: --- → ?
(Assignee)

Comment 2

3 years ago
Created attachment 8588369 [details]
MozReview Request: bz://1151145/mstange

/r/6641 - Bug 1151145 - Make sure we don't call CGContextSaveGState without calling CGContextRestoreGState in DrawTargetCG::StrokeRect. r=jrmuizel
/r/6643 - Bug 1151145 - Add assertions to detect unbalanced calls to CGContextSaveGState / CGContextRestoreGState. r=jrmuizel
/r/6645 - Bug 1151145 - Add a reftest. r=jrmuizel

Pull down these commits:

hg pull -r 217cae83dc010f3bc76019873a382df62f38b3b9 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8588369 - Flags: review?(jmuizelaar)
https://reviewboard.mozilla.org/r/6645/#review5511

Ship It!
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/852527d009a4
https://hg.mozilla.org/integration/mozilla-inbound/rev/135120efabd3
https://hg.mozilla.org/integration/mozilla-inbound/rev/92b866002a30
(Assignee)

Updated

3 years ago
Attachment #8588369 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8588369 [details]
MozReview Request: bz://1151145/mstange

Approval Request Comment
[Feature/regressing bug #]: bug 1123019
[User impact if declined]: drawing corruption
[Describe test coverage new/current, TreeHerder]: this patch adds a test
[Risks and why]: extremely low
[String/UUID change made/needed]: none
Attachment #8588369 - Flags: approval-mozilla-aurora?
tracking-firefox39: ? → +
https://hg.mozilla.org/mozilla-central/rev/852527d009a4
https://hg.mozilla.org/mozilla-central/rev/135120efabd3
https://hg.mozilla.org/mozilla-central/rev/92b866002a30
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8588369 [details]
MozReview Request: bz://1151145/mstange

Approved for uplift to aurora, low risk, includes tests.
Attachment #8588369 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Since this fixes a regression I'd like us to get QE verification on this fix (on Nightly and Aurora). Florin is this something your team can take on? Thanks.
Flags: qe-verify+
Flags: needinfo?(florin.mezei)
Keywords: regression
https://hg.mozilla.org/releases/mozilla-aurora/rev/c4248bd6b7c3
https://hg.mozilla.org/releases/mozilla-aurora/rev/969ad710b89e
https://hg.mozilla.org/releases/mozilla-aurora/rev/77b9d633dfb9
status-firefox39: affected → fixed
Reproduced this issue on Mac OS X 10.9.5 using 2015-04-03 Nightly.

Confirming the fix on Mac OS X 10.9.5, Windows 7 64-bit and Ubuntu 12.04 32-bit using:
- latest Nightly, build ID: 20150416030209.
- latest Aurora, build ID: 20150416004008.
Status: RESOLVED → VERIFIED
status-firefox39: fixed → verified
status-firefox40: fixed → verified
Flags: needinfo?(florin.mezei)
QA Contact: cornel.ionce
(Assignee)

Comment 11

3 years ago
Comment on attachment 8588369 [details]
MozReview Request: bz://1151145/mstange
Attachment #8588369 - Attachment is obsolete: true
Attachment #8619971 - Flags: review+
Attachment #8619972 - Flags: review+
Attachment #8619973 - Flags: review+
(Assignee)

Comment 12

3 years ago
Created attachment 8619971 [details]
MozReview Request: Bug 1151145 - Make sure we don't call CGContextSaveGState without calling CGContextRestoreGState in DrawTargetCG::StrokeRect. r=jrmuizel
(Assignee)

Comment 13

3 years ago
Created attachment 8619972 [details]
MozReview Request: Bug 1151145 - Add assertions to detect unbalanced calls to CGContextSaveGState / CGContextRestoreGState. r=jrmuizel
(Assignee)

Comment 14

3 years ago
Created attachment 8619973 [details]
MozReview Request: Bug 1151145 - Add a reftest. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.