1151157 - Add printing support to Firefox for iOS

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement)

Description

[Eric Shepherd [:sheppy]]

There currently doesn't seem to be any support for printing from Firefox for iOS. This made me sad last night when I used it to place an order and wasn't able to save my receipt other than as a somewhat hard-to-read screenshot.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I doubt we'll try to get this in v1

Comment 2

[adiyaman]

I would like to work on this.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/334

Comment 4

[adiyaman]

Attachment: Pull request

Comment 5

[Richard Newman [:rnewman]]

We'll take it, but not tracking.

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 8625274 [details] [review]
Pull request

There's something strange with the PR here (i.e. its got a ton of commits from master in it?) Maybe you just need to rebase back onto master?

Other than that and a few tiny nits, looks good!

Comment 7

[adiyaman]

I fixed the nits and rebased it. Could you please review it again?

(In reply to Wesley Johnston (:wesj) from comment #6)
> Comment on attachment 8625274 [details] [review]
> Pull request
> 
> There's something strange with the PR here (i.e. its got a ton of commits
> from master in it?) Maybe you just need to rebase back onto master?
> 
> Other than that and a few tiny nits, looks good!

Comment 8

[Aaron Train [:aaronmt]]

New PR @ https://github.com/mozilla/firefox-ios/pull/635

Comment 9

[James Hugman [:jhugman] [@jhugman]]

Rebased and merged into master https://github.com/mozilla/firefox-ios/pull/635